Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add python3 symlink in final container #2085

Merged
merged 1 commit into from
Jul 7, 2023
Merged

fix: Add python3 symlink in final container #2085

merged 1 commit into from
Jul 7, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Jul 7, 2023

Description

  • Enable libtorch sourcing from WORKSPACE file in Docker container

Addresses #1560

Type of change

  • Container improvement

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
fix: Add python3 symlink in final container
30bff67 
- Enable libtorch finding from WORKSPACE file in Docker container
@gs-olive gs-olive self-assigned this Jul 7, 2023
@gs-olive gs-olive mentioned this pull request Jul 7, 2023
Closed
gs-olive
gs-olive commented Jul 7, 2023
View reviewed changes
docker/Dockerfile
Comment on lines +98 to +100
# Symlink the path pyenv is using for python with the /opt directory for package sourcing
RUN mkdir -p "/opt/python3/" &&\
ln -s "`pyenv which python | xargs dirname | xargs dirname`/lib/python$PYTHON_VERSION/site-packages" "/opt/python3/"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated from above. It is necessary to add this symbolic link again in the main container to ensure rebuilds of Torch-TRT by the user are functional.

narendasan
narendasan approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive merged commit 44e4ffa into pytorch:main Jul 7, 2023
@gs-olive gs-olive deleted the docker_cpp_build_fix branch July 7, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

Assignees

@gs-olive gs-olive

Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gs-olive @narendasan @facebook-github-bot