Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Repair graph naming for FX legacy suite #2111

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

gs-olive
Copy link
Collaborator

@gs-olive gs-olive commented Jul 13, 2023

Description

  • Switches between num_users and #users based on Torch version

Changed here: pytorch/pytorch#101140

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive gs-olive self-assigned this Jul 13, 2023
@github-actions github-actions bot requested a review from frank-wei July 13, 2023 17:48
@gs-olive gs-olive requested a review from peri044 July 13, 2023 17:50
@gs-olive gs-olive added the WIP Work is in progress, pull request should not be merged yet label Jul 13, 2023
Copy link
Collaborator

@peri044 peri044 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gs-olive gs-olive removed the WIP Work is in progress, pull request should not be merged yet label Jul 13, 2023
@gs-olive gs-olive merged commit 9cb57c2 into pytorch:main Jul 13, 2023
@gs-olive gs-olive deleted the num_users_legacy_fix branch July 13, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants