abandoned create_plugin() function #2146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In TensorRT 8.6.1.6, we don't need to call
create_plugin()
foralign_corners=true
in core/conversion/converters/impl/interpolate.cpp. Instead, we can directly callresize_layer_size()
asalign_corners=false
. Thus, I think maybe we can remove the plugins and let TRT run it.create_plugin()
function falls back to let Torch run it, which is slower than TRT running it.Type of change
Checklist: