-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamo converter support for torch.ops.aten.erf.default op #2164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
--- py/torch_tensorrt/dynamo/conversion/impl/unary/ops.py 2023-08-02 22:53:30.255742 +0000
+++ py/torch_tensorrt/dynamo/conversion/impl/unary/ops.py 2023-08-02 22:53:47.940338 +0000
@@ -105,6 +105,6 @@
name: str,
input_val: TRTTensor,
) -> TRTTensor:
return convert_unary(
network, target, source_ir, name, trt.UnaryOperation.ERF, input_val
- )
\ No newline at end of file
+ )
--- tests/py/dynamo/converters/test_erf_aten.py 2023-08-02 22:53:30.271743 +0000
+++ tests/py/dynamo/converters/test_erf_aten.py 2023-08-02 22:53:51.635953 +0000
@@ -19,6 +19,6 @@
expected_ops={torch.ops.aten.erf.default},
)
if __name__ == "__main__":
- run_tests()
\ No newline at end of file
+ run_tests()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to Python style guidelines:
--- py/torch_tensorrt/dynamo/conversion/impl/unary/ops.py 2023-08-02 22:53:32.723785 +0000
+++ py/torch_tensorrt/dynamo/conversion/impl/unary/ops.py 2023-08-02 22:53:51.305560 +0000
@@ -105,6 +105,6 @@
name: str,
input_val: TRTTensor,
) -> TRTTensor:
return convert_unary(
network, target, source_ir, name, trt.UnaryOperation.ERF, input_val
- )
\ No newline at end of file
+ )
--- tests/py/dynamo/converters/test_erf_aten.py 2023-08-02 22:53:32.743787 +0000
+++ tests/py/dynamo/converters/test_erf_aten.py 2023-08-02 22:53:55.515767 +0000
@@ -19,6 +19,6 @@
expected_ops={torch.ops.aten.erf.default},
)
if __name__ == "__main__":
- run_tests()
\ No newline at end of file
+ run_tests()
@bowang007 run the linter |
f25c41f
to
3c4c2fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
Description
This PR support dynamo converter for
torch.erf
Checklist: