feat: Transition export workflows to use torch._export APIs #2195

peri044 · 2023-08-11T23:02:14Z

Description

Use torch._export APIs to trace instead of dynamo export.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Checklist:

My code follows the style guidelines of this project (You can use the linters)
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas and hacks
I have made corresponding changes to the documentation
I have added tests to verify my fix or my feature
New and existing unit tests pass locally with my changes
I have added the relevant labels to my PR in so that relevant reviewers are notified

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

py/torch_tensorrt/dynamo/__init__.py

py/torch_tensorrt/dynamo/aten_tracer.py

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

fix: Refactor tensor freezing in Dynamo Key op fixes for failing tests

…t_prototype

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

gs-olive

Looks good! Left some comments and general suggestions.

py/torch_tensorrt/dynamo/aten_tracer.py

tests/py/dynamo/models/test_models_export.py

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

github-actions

Code conforms to Python style guidelines

gs-olive

Looks good to me, pending CI

gs-olive · 2023-09-13T00:42:24Z

For some reason this error is not being shown on main, but I think you could change:

import torch_tensorrt

... torch_tensorrt.sanitized_torch_version() ...

To:

from torch_tensorrt._utils import sanitized_torch_version

... sanitized_torch_version() ...

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions

Code conforms to C++ style guidelines

github-actions

Code conforms to Python style guidelines

peri044 added 3 commits August 8, 2023 10:45

feat: Move tracing to use aot export apis

f1f202e

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

chore: minor changes

abaf047

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

chore: minor changes

bb1f3cf

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

facebook-github-bot added the cla signed label Aug 11, 2023

github-actions bot added component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Aug 11, 2023

github-actions bot requested a review from gs-olive August 11, 2023 23:02

chore: Rebase with main

3d05b4d

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Aug 11, 2023

View reviewed changes

narendasan reviewed Aug 13, 2023

View reviewed changes

py/torch_tensorrt/dynamo/__init__.py Outdated Show resolved Hide resolved

narendasan reviewed Aug 13, 2023

View reviewed changes

py/torch_tensorrt/dynamo/aten_tracer.py Outdated Show resolved Hide resolved

gs-olive reviewed Aug 14, 2023

View reviewed changes

py/torch_tensorrt/dynamo/aten_tracer.py Outdated Show resolved Hide resolved

gs-olive reviewed Aug 14, 2023

View reviewed changes

py/torch_tensorrt/dynamo/aten_tracer.py Show resolved Hide resolved

chore: rebase

8d99be5

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Aug 16, 2023

View reviewed changes

peri044 and others added 6 commits August 16, 2023 17:05

chore: minor logging updates

0aad214

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

feat: Add preliminary support for freezing tensors in Dynamo

8899735

fix: Refactor tensor freezing in Dynamo

8af2627

Key op fixes for failing tests

f6969be

fix: Add constant folding utility to freezing

bad1594

chore: Move to new export APIs

db56dd6

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot added the component: torch_compile label Aug 17, 2023

peri044 changed the base branch from main to dynamo_tensor_freeze August 17, 2023 20:12

chore: rebase with dynamo_tensor_freeze branch

bf961f5

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Aug 17, 2023

View reviewed changes

gs-olive added 2 commits August 17, 2023 15:10

feat: Add preliminary support for freezing tensors in Dynamo

b13aa82

fix: Refactor tensor freezing in Dynamo

dd95620

github-actions bot approved these changes Sep 11, 2023

View reviewed changes

gs-olive added 5 commits September 11, 2023 11:02

feat: Add preliminary support for freezing tensors in Dynamo

399f929

fix: Refactor tensor freezing in Dynamo Key op fixes for failing tests

fix: Add constant folding utility to freezing

4b44ff2

fix: Move tracer code into try/except

a94a075

Custom implementation of AOT for compile

4e308f1

Move fixes into Dynamo directory

95d3f98

gs-olive force-pushed the dynamo_tensor_freeze branch from 0005a31 to 95d3f98 Compare September 11, 2023 18:02

Merge remote-tracking branch 'origin/dynamo_tensor_freeze' into expor…

529262a

…t_prototype

github-actions bot approved these changes Sep 11, 2023

View reviewed changes

Base automatically changed from dynamo_tensor_freeze to main September 12, 2023 01:20

chore: rebase

aee529b

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Sep 12, 2023

View reviewed changes

gs-olive reviewed Sep 12, 2023

View reviewed changes

py/torch_tensorrt/dynamo/aten_tracer.py Outdated Show resolved Hide resolved

tests/py/dynamo/models/test_models_export.py Outdated Show resolved Hide resolved

tests/py/dynamo/models/test_models_export.py Outdated Show resolved Hide resolved

peri044 added 2 commits September 12, 2023 16:43

chore: address review comments

e6d2d8d

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

Merge branch 'main' into export_prototype

6cd2bab

peri044 requested a review from gs-olive September 12, 2023 23:44

github-actions bot approved these changes Sep 12, 2023

View reviewed changes

gs-olive approved these changes Sep 13, 2023

View reviewed changes

chore: fix imports

c7b2f3c

Signed-off-by: Dheeraj Peri <peri.dheeraj@gmail.com>

github-actions bot approved these changes Sep 13, 2023

View reviewed changes

peri044 merged commit c1f130a into main Sep 18, 2023
22 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Transition export workflows to use torch._export APIs #2195

feat: Transition export workflows to use torch._export APIs #2195

peri044 commented Aug 11, 2023

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

gs-olive left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

gs-olive left a comment •

edited

Loading

gs-olive commented Sep 13, 2023

github-actions bot left a comment

github-actions bot left a comment

feat: Transition export workflows to use torch._export APIs #2195

feat: Transition export workflows to use torch._export APIs #2195

Conversation

peri044 commented Aug 11, 2023

Description

Type of change

Checklist:

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

gs-olive left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

gs-olive left a comment • edited Loading

Choose a reason for hiding this comment

gs-olive commented Sep 13, 2023

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

gs-olive left a comment •

edited

Loading