fix: Legacy CI pip installation
#2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gs-olive
added
the
WIP
gs-olive
force-pushed
the
legacy_ci_install_fix
branch
2 times, most recently
from
53b746a
to
d79ed9b
Compare
gs-olive
force-pushed
the
legacy_ci_install_fix
branch
from
d79ed9b
to
3d404b9
Compare
gs-olive
force-pushed
the
legacy_ci_install_fix
branch
2 times, most recently
from
9333bbc
to
6b6593c
Compare
|
toolchains special toml for legacy |
gs-olive
force-pushed
the
legacy_ci_install_fix
branch
from
6b6593c
to
28ba56f
Compare
gs-olive
force-pushed
the
legacy_ci_install_fix
branch
from
e03e94d
to
01bb7fb
Compare
gs-olive
force-pushed
the
legacy_ci_install_fix
branch
from
01bb7fb
to
158ada3
Compare
gs-olive
force-pushed
the
legacy_ci_install_fix
branch
from
1507b13
to
fe16044
Compare
gs-olive
requested review from
peri044 and
narendasan
and removed request for
peri044
gs-olive
commented
Aug 23, 2023
| @@ -93,13 +100,14 @@ def _get_target_ir(module_type: _ModuleType, ir: str) -> _IRType: | |||
| else: | |||
| if ir == "default": | |||
| # Options are listed in order of preference | |||
| if module_is_fxable: | |||
| if DYNAMO_ENABLED and module_is_fxable: | |||
There was a problem hiding this comment.
Update default path to be TorchScript if the install is with a legacy Torch version
gs-olive
removed
the
WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.yamlto support legacy CI testing, including upgraded.tomlandWORKSPACEfiles built specifically for the legacy versioncompile()to be TorchScript in the legacy install