Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add support for negative dimensions in reduce #2347

Merged
merged 1 commit into from
Sep 29, 2023
Merged

fix: Add support for negative dimensions in reduce #2347

merged 1 commit into from
Sep 29, 2023

Conversation

gs-olive
Copy link
Collaborator

Description

  • Add key converter utility for getting positive dimension from negative counterpart, including extensions for getting positive dimension from a Sequence of input dimensions
  • Update implementations across the library of converters
  • Update test cases, including regression test

Fixes #2342

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [ x ] My code follows the style guidelines of this project (You can use the linters)
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have commented my code, particularly in hard-to-understand areas and hacks
  • [ x ] I have made corresponding changes to the documentation
  • [ x ] I have added tests to verify my fix or my feature
  • [ x ] New and existing unit tests pass locally with my changes
  • [ x ] I have added the relevant labels to my PR in so that relevant reviewers are notified

@gs-olive
fix: Add support for negative dimensions in reduce
216268d 
- Add key converter utility for getting positive dimension from negative
counterpart, including extensions for getting positive dimension from
a Sequence of input dimensions
- Update implementations across the library of converters
- Update test cases, including regression test
@gs-olive gs-olive self-assigned this Sep 25, 2023
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests labels Sep 25, 2023
github-actions[bot]
github-actions bot approved these changes Sep 25, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 25, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 25, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 25, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 25, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Sep 25, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

zewenli98
zewenli98 approved these changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@zewenli98 zewenli98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Looks good to me.

@gs-olive gs-olive merged commit 46cfa35 into main Sep 29, 2023
23 checks passed
@gs-olive gs-olive deleted the concat_fix branch September 29, 2023 20:39
@zewenli98 zewenli98 mentioned this pull request Sep 30, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@zewenli98 zewenli98 zewenli98 approved these changes

@apbose apbose Awaiting requested review from apbose

@peri044 peri044 Awaiting requested review from peri044

Assignees

@gs-olive gs-olive

Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: tests Issues re: Tests priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue when invoking reduction converters with negative dimensions
3 participants
@gs-olive @zewenli98 @facebook-github-bot