Use importlib.util.find_spec to check if lm_eval is installed instead of trying to import it
#1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of trying to import it There is a circular dependency when trying to import lm_eval inside torchao. The chain is like this: torchao -> lm_eval -> transformers.pipelines -> torchao And results in the following error: RuntimeError: Failed to import transformers.pipelines because of the following error (look up to see its traceback): cannot import name 'quantize_' from partially initialized module 'torchao.quantization' which 1. causes _lm_eval_available to be erroneously set to False, even if lm_eval is available 2. interrupts lm_eval's initialization, leaving it partially initialized you can observe this with: >>> import torchao >>> import lm_eval.__main__ >>> import lm_eval.api.registry >> lm_eval.api.registry AttributeError: module 'lm_eval' has no attribute 'api' Having a bare except clause here was suppressing this circular import error, which from glancing around seems kind of like a general pattern in this code base. It might be worth reconsidering this pattern.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1023
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 198ac0d with merge base c187f87 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
Yeah not a huge fan of naked excepts either, if you wanna submit a few patches, would be happy to merge them |
msaroufim
approved these changes
Oct 7, 2024
jainapurva
pushed a commit
that referenced
this pull request
Oct 15, 2024
…tead of trying to import it (#1023) Use importlib.util.find_spec to check if lm_eval is installed instead of trying to import it There is a circular dependency when trying to import lm_eval inside torchao. The chain is like this: torchao -> lm_eval -> transformers.pipelines -> torchao And results in the following error: RuntimeError: Failed to import transformers.pipelines because of the following error (look up to see its traceback): cannot import name 'quantize_' from partially initialized module 'torchao.quantization' which 1. causes _lm_eval_available to be erroneously set to False, even if lm_eval is available 2. interrupts lm_eval's initialization, leaving it partially initialized you can observe this with: >>> import torchao >>> import lm_eval.__main__ >>> import lm_eval.api.registry >> lm_eval.api.registry AttributeError: module 'lm_eval' has no attribute 'api' Having a bare except clause here was suppressing this circular import error, which from glancing around seems kind of like a general pattern in this code base. It might be worth reconsidering this pattern.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a circular dependency when trying to import
lm_evalinsidetorchao. The chain is like this:torchao -> lm_eval -> transformers.pipelines -> torchao
And results in the following error:
which
_lm_eval_availableto be erroneously set toFalse, even iflm_evalis availablelm_eval'sinitialization, leaving it partially initializedyou can observe this with:
Having a bare except clause here was suppressing this circular import error, which from glancing around seems kind of like a general pattern in this code base. It might be worth reconsidering this pattern.