Uintx ops - Slice etc... #1026
Draft
Uintx ops - Slice etc... #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1026
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
6 tasks
vayuda
reviewed
Oct 9, 2024
| @@ -55,6 +56,7 @@ class UintxTensor(TorchAOBaseTensor): | |||
| def __new__( | |||
| cls, | |||
| shards: List[torch.Tensor], | |||
| original_size: int, | |||
There was a problem hiding this comment.
what is this parameter used for? Just seems like its getting passed around
There was a problem hiding this comment.
It is used in the unpack function
def get_plain(self): return unpack(self.get_shards(), original_size=self.original_size, elem_size=self.bit_width, dim = self.pack_dim)
fix _repr_ and scalar assigment in UintxTensor add basic slice test for uint6 add generic slice tests for uint1-7
melvinebenezer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuation to #458 and #988
ToDo