cmake torchao_ops_mps_linear_fp_act_xbit_weight #1304

manuelcandales · 2024-11-18T21:23:37Z

Summary: Move from setup.py to cmake for building custom torchao mps ops

Differential Revision: D66120124

pytorch-bot · 2024-11-18T21:23:40Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1304

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

[DomainsOnly] Jobs fail with GLIBC version not found

✅ No Failures

As of commit a388689 with merge base ca52cdc ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2024-11-18T21:24:10Z

This pull request was exported from Phabricator. Differential Revision: D66120124

kimishpatel · 2024-11-18T22:04:11Z

torchao/experimental/ops/mps/CMakeLists.txt

+target_compile_definitions(torchao_ops_mps_linear_fp_act_xbit_weight_aten PRIVATE USE_ATEN=1)
+
+# Enable Metal support
+if (APPLE)


Do we need to gate from specific version of OS? I think we should. both iOS and MacOS

kimishpatel

mostly nits, but one question on file removal

kimishpatel · 2024-11-18T22:05:31Z

torchao/experimental/ops/mps/build.sh

+    -B ${CMAKE_OUT}
+cmake --build  ${CMAKE_OUT} -j 16 --target install --config Release
+
+rm ../../kernels/mps/src/metal_shader_lib.h


wait what is this?

after I am done building and installing, I don't need the generated metal_shader_lib.h anymore.

ok then generated artifacts should be stored in build directory as temporary artifacts or somewhere else. Adding in the repo folder and removing it can leave the repo in dirty state if build fails. Also generally clean

torchao/experimental/ops/mps/build.sh

kimishpatel · 2024-11-18T22:41:17Z

torchao/experimental/ops/mps/build.sh

+
+python ../../kernels/mps/codegen/gen_metal_shader_lib.py
+
+export CMAKE_PREFIX_PATH=$(python -c 'from distutils.sysconfig import get_python_lib; print(get_python_lib())')


why cmake prefix path points to site-packages?

that's where the cmake stuff is. I am working on a conda environment.

what do you mean thats where the cmake stuff is. prefix path is used for looking up packages https://cmake.org/cmake/help/latest/variable/CMAKE_PREFIX_PATH.html and other stuff

kimishpatel · 2024-11-18T22:43:28Z

torchao/experimental/ops/mps/test/test_lowbit.py

+path_libtorchao_ops_mps_aten = os.path.abspath(
+    os.path.join(
+        os.path.dirname(__file__), "../cmake-out/lib/libtorchao_ops_mps_linear_fp_act_xbit_weight_aten.dylib"
+    )
+)
+torch.ops.load_library(path_libtorchao_ops_mps_aten)


If and when we integrate experimental with torchao's pip installation, like pip install . or setup then at that type this lib should be installed in site-packages or some place like that instead of making it available via cmake-out in this way

Put it under try catch and throw error message if not found

kimishpatel

mostly nits, but one question on file removal

facebook-github-bot · 2024-11-19T20:04:52Z

This pull request was exported from Phabricator. Differential Revision: D66120124

Summary: Pull Request resolved: pytorch#1304 Move from setup.py to cmake for building custom torchao mps ops Differential Revision: D66120124

facebook-github-bot · 2024-11-19T20:45:53Z

This pull request was exported from Phabricator. Differential Revision: D66120124

Summary: Pull Request resolved: pytorch#1304 Move from setup.py to cmake for building custom torchao mps ops Differential Revision: D66120124

facebook-github-bot · 2024-11-19T20:52:13Z

This pull request was exported from Phabricator. Differential Revision: D66120124

Summary: Pull Request resolved: pytorch#1304 Move from setup.py to cmake for building custom torchao mps ops Differential Revision: D66120124

facebook-github-bot · 2024-11-20T02:20:17Z

This pull request was exported from Phabricator. Differential Revision: D66120124

Summary: Pull Request resolved: pytorch#1304 Move from setup.py to cmake for building custom torchao mps ops Differential Revision: D66120124

facebook-github-bot · 2024-11-20T02:26:13Z

This pull request was exported from Phabricator. Differential Revision: D66120124

kimishpatel

Stamping for now. Do consider addressing comments before landing

torchao/experimental/ops/mps/build.sh

torchao/experimental/ops/mps/test/test_lowbit.py

torchao/experimental/ops/mps/test/test_quantizer.py

facebook-github-bot · 2024-11-20T21:11:57Z

This pull request was exported from Phabricator. Differential Revision: D66120124

Summary: Pull Request resolved: pytorch#1304 Move from setup.py to cmake for building custom torchao mps ops Differential Revision: D66120124

facebook-github-bot · 2024-11-20T21:18:07Z

This pull request was exported from Phabricator. Differential Revision: D66120124

Summary: Pull Request resolved: pytorch#1304 Move from setup.py to cmake for building custom torchao mps ops Differential Revision: D66120124

facebook-github-bot · 2024-11-21T18:00:30Z

This pull request was exported from Phabricator. Differential Revision: D66120124

facebook-github-bot · 2024-11-21T18:11:24Z

This pull request was exported from Phabricator. Differential Revision: D66120124

Summary: Pull Request resolved: pytorch#1304 Move from setup.py to cmake for building custom torchao mps ops Reviewed By: kimishpatel Differential Revision: D66120124

facebook-github-bot · 2024-11-21T18:24:24Z

This pull request was exported from Phabricator. Differential Revision: D66120124

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2024

facebook-github-bot added the fb-exported label Nov 18, 2024

manuelcandales added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Nov 18, 2024

manuelcandales requested a review from kimishpatel November 18, 2024 21:58

kimishpatel reviewed Nov 18, 2024

View reviewed changes

kimishpatel requested changes Nov 18, 2024

View reviewed changes

manuelcandales force-pushed the export-D66120124 branch from 9e2bda1 to 3f7ef3b Compare November 19, 2024 20:05

manuelcandales force-pushed the export-D66120124 branch from 3f7ef3b to 20a5673 Compare November 19, 2024 20:46

manuelcandales force-pushed the export-D66120124 branch from 20a5673 to a3bb86d Compare November 19, 2024 20:52

manuelcandales requested a review from kimishpatel November 19, 2024 20:52

manuelcandales force-pushed the export-D66120124 branch from a3bb86d to 249a823 Compare November 20, 2024 02:20

manuelcandales force-pushed the export-D66120124 branch from 249a823 to efea60e Compare November 20, 2024 02:26

kimishpatel approved these changes Nov 20, 2024

View reviewed changes

manuelcandales force-pushed the export-D66120124 branch from efea60e to a6c04fa Compare November 20, 2024 21:12

manuelcandales force-pushed the export-D66120124 branch from a6c04fa to 4aa2983 Compare November 20, 2024 21:18

manuelcandales force-pushed the export-D66120124 branch from 4aa2983 to 560f37a Compare November 21, 2024 18:00

manuelcandales force-pushed the export-D66120124 branch from 560f37a to 32fc0e7 Compare November 21, 2024 18:11

cmake torchao_ops_mps_linear_fp_act_xbit_weight (pytorch#1304)

a388689

Summary: Pull Request resolved: pytorch#1304 Move from setup.py to cmake for building custom torchao mps ops Reviewed By: kimishpatel Differential Revision: D66120124

manuelcandales force-pushed the export-D66120124 branch from 32fc0e7 to a388689 Compare November 21, 2024 18:24

facebook-github-bot merged commit 7489c7d into pytorch:main Nov 21, 2024
19 of 20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmake torchao_ops_mps_linear_fp_act_xbit_weight #1304

cmake torchao_ops_mps_linear_fp_act_xbit_weight #1304

manuelcandales commented Nov 18, 2024

pytorch-bot bot commented Nov 18, 2024 •

edited

Loading

facebook-github-bot commented Nov 18, 2024

kimishpatel Nov 18, 2024

kimishpatel left a comment

kimishpatel Nov 18, 2024

manuelcandales Nov 19, 2024

kimishpatel Nov 19, 2024

kimishpatel Nov 18, 2024

manuelcandales Nov 19, 2024

kimishpatel Nov 19, 2024

kimishpatel Nov 18, 2024

kimishpatel left a comment

facebook-github-bot commented Nov 19, 2024

facebook-github-bot commented Nov 19, 2024

facebook-github-bot commented Nov 19, 2024

facebook-github-bot commented Nov 20, 2024

facebook-github-bot commented Nov 20, 2024

kimishpatel left a comment

facebook-github-bot commented Nov 20, 2024

facebook-github-bot commented Nov 20, 2024

facebook-github-bot commented Nov 21, 2024

facebook-github-bot commented Nov 21, 2024

facebook-github-bot commented Nov 21, 2024


		python ../../kernels/mps/codegen/gen_metal_shader_lib.py

		export CMAKE_PREFIX_PATH=$(python -c 'from distutils.sysconfig import get_python_lib; print(get_python_lib())')

cmake torchao_ops_mps_linear_fp_act_xbit_weight #1304

cmake torchao_ops_mps_linear_fp_act_xbit_weight #1304

Conversation

manuelcandales commented Nov 18, 2024

pytorch-bot bot commented Nov 18, 2024 • edited Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1304

❗ 1 Active SEVs

✅ No Failures

facebook-github-bot commented Nov 18, 2024

Choose a reason for hiding this comment

kimishpatel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kimishpatel left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Nov 19, 2024

facebook-github-bot commented Nov 19, 2024

facebook-github-bot commented Nov 19, 2024

facebook-github-bot commented Nov 20, 2024

facebook-github-bot commented Nov 20, 2024

kimishpatel left a comment

Choose a reason for hiding this comment

facebook-github-bot commented Nov 20, 2024

facebook-github-bot commented Nov 20, 2024

facebook-github-bot commented Nov 21, 2024

facebook-github-bot commented Nov 21, 2024

facebook-github-bot commented Nov 21, 2024

pytorch-bot bot commented Nov 18, 2024 •

edited

Loading