Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[float8] Allow specifying arbitrary dtype for each tensor #1378

Merged
merged 6 commits into from
Dec 4, 2024
Merged

[float8] Allow specifying arbitrary dtype for each tensor #1378

merged 6 commits into from
Dec 4, 2024

Conversation

lw
Copy link
Contributor

@lw lw commented Dec 4, 2024 •
edited
Loading

No description provided.

lw added 2 commits December 4, 2024 15:55
@lw
Update
b91f59b 
[ghstack-poisoned]
@lw
Update
847f012 
[ghstack-poisoned]
@lw
Copy link
Contributor Author

lw commented Dec 4, 2024 •
edited
Loading

Stack from ghstack (oldest at bottom):

@lw lw mentioned this pull request Dec 4, 2024
Merged
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Dec 4, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1378

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 New Failures

As of commit 50e3479 with merge base 6a177c9 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

lw added a commit that referenced this pull request Dec 4, 2024
@lw
[float8] Allow specifying arbitrary dtype for each tensor
e8c5769 
ghstack-source-id: d8300e2a07c087f3cd51b03e0e21125a83a29489
ghstack-comment-id: 2517857809
Pull Request resolved: #1378
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2024
@lw lw mentioned this pull request Dec 4, 2024
Draft
@lw
Copy link
Contributor Author

lw commented Dec 4, 2024

Resubmission of #1326

@lw lw added the topic: new feature Use this tag if this PR adds a new feature label Dec 4, 2024
@lw
Update
c1cdb55 
[ghstack-poisoned]
lw added a commit that referenced this pull request Dec 4, 2024
@lw
[float8] Allow specifying arbitrary dtype for each tensor
aa0587f 
ghstack-source-id: 5cc007cd363033e95314a20b70f7ded4144b7842
ghstack-comment-id: 2517857809
Pull Request resolved: #1378
lw added 2 commits December 4, 2024 18:14
@lw
Update
d3aba66 
[ghstack-poisoned]
@lw
Update
41e7d56 
[ghstack-poisoned]
lw added a commit that referenced this pull request Dec 4, 2024
@lw
[float8] Allow specifying arbitrary dtype for each tensor
42afacd 
ghstack-source-id: b1066f120ce72b774b5d226d5a43f58e0021bd91
ghstack-comment-id: 2517857809
Pull Request resolved: #1378
Base automatically changed from gh/lw/3/head to main December 4, 2024 21:13
@lw
Update
50e3479 
[ghstack-poisoned]
lw added a commit that referenced this pull request Dec 4, 2024
@lw
[float8] Allow specifying arbitrary dtype for each tensor
ca479a1 
ghstack-source-id: b1066f120ce72b774b5d226d5a43f58e0021bd91
ghstack-comment-id: 2517857809
Pull Request resolved: #1378
@lw lw merged commit 4f8021f into main Dec 4, 2024
19 of 37 checks passed
@lw lw deleted the gh/lw/4/head branch December 4, 2024 21:14
yanbing-j added a commit to yanbing-j/ao that referenced this pull request Dec 9, 2024
@yanbing-j @Jack-Khuu
Ignore tokens per sec from jit_compile iteration (pytorch#1378)
a6a6e61 
* Remove tokens per sec in aggregate_metrics when jit_compile

* Add warning to user

* Update

---------

Co-authored-by: Jack-Khuu <jack.khuu.7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkuzo vkuzo vkuzo approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: new feature Use this tag if this PR adds a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lw @vkuzo @facebook-github-bot