-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve FP6-LLM 2+4bit weight splitting + user API #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/279
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d798eaf with merge base 4ca3985 (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
label
May 25, 2024
Open
gau-nernst
changed the title
Improve FP6-LLM 2+4bit weight splitting
Improve FP6-LLM 2+4bit weight splitting + user API
May 26, 2024
msaroufim
approved these changes
May 26, 2024
msaroufim
approved these changes
May 26, 2024
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
* add annotation * add weight splitting logic * update from fp6_quant * merge to_tc_float6_e3m2 * add more optimized version * add some notes * add from_tc_float6_e3m2 * add some docs * make fp6_llm.py * add test for linear * fix fp6 llm * switch to v2 since it's faster * fix type hint for old python * simplify further * fix typing for old python * add test * eliminate indexing.faster on CUDA * skip fp6_llm on cpu * improve error message * add support for extra batch dims * cast output to original dtype * fix precision error due to dtype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #208
2+4bit weight splitting
Port https://github.com/pytorch/ao/blob/4ca3985be603e6496da7ec57adf1942c8b32a78e/torchao/csrc/fp6_llm/weight_prepacking.cpp to pure PyTorch.
FP16 weight, (8192, 8192). Ryzen 5600, 4070Ti SUPER
Note:
original 2+4bit splitting
only works on CPU. Thus, for the 2nd last row, FP16->FP6 is done on GPU, but 2+4bit splitting is done on CPU.User API
I opt for custom linear module instead of tensor subclass mainly because it's easier to implement.
Note:
Fp6LlmLinear
will cast input to FP16 and cast output to original dtype.