Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bitpacking #291
Bitpacking #291
Changes from 18 commits
37e4d2d
b37b529
f834885
33845fe
3e7ca9b
88fe113
3e1813a
80b9a41
036334c
6a02cc1
61d3666
47d9c92
5bdef89
8d1ea34
6e1a7d6
46e39fd
dcada3e
a5dd25d
5ec3deb
6e9a738
189677d
4e5b8a5
98cf146
c8055b2
45b990c
74f03e2
ae91c6c
e1253b5
f6758e9
68179e8
4ce1295
b01550f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious.
container_size
can be determined fromdata.dtype
right? e.g. uint8 -> 8, uint16 -> 16. (there is also this - https://pytorch.org/docs/stable/type_info.html#torch.torch.iinfo).Also, is it assumed that
data.dtype
hascontainer_size
number of bits? What ifdata
use larger or smaller bit-width thancontainer_size
? e.g. store int4 in int32, then request to pack to int8. Depending on what are your assumptions to the inputs, perhaps some kind of type checking and/or type casting is good.