073 scripts for benchmarks #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HDCharles
commented
Jun 15, 2024
HDCharles
commented
Summary: Added instructions for downloading model weights, and model weight download scripts. Test Plan: huggingface-cli login sh ./scripts/prepare.sh Reviewers: Subscribers: Tasks: Tags:
Summary: Test Plan: sh benchmarks.sh Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/372
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f0de569 with merge base bc2f8b7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
vayuda
reviewed
Jun 18, 2024
There was a problem hiding this comment.
I think it would be nice if the model name could be passed as a command line parameter because then I can selectively download one at a time, but also it is just two commands so its not really a big deal either way
There was a problem hiding this comment.
you can use the download.py script to do that, prepare is supposed to be setup to directly handle the things we advertise as our benchmarks
vayuda
approved these changes
Jun 18, 2024
dbyoung18
pushed a commit
to dbyoung18/ao
that referenced
this pull request
Jul 31, 2024
* Instructions for downloading model weights Summary: Added instructions for downloading model weights, and model weight download scripts. Test Plan: huggingface-cli login sh ./scripts/prepare.sh Reviewers: Subscribers: Tasks: Tags: * updating paths to model checkpoint dir Summary: Test Plan: sh benchmarks.sh Reviewers: Subscribers: Tasks: Tags: * added checkpoints folder to git ignore --------- Co-authored-by: vayuda <120random.things@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.