Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Quantization subclass Int8DynamicallyQuantizedLinearWeight typo #860

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

YihengBrianWu
Copy link
Contributor

This PR fix a typo of Int8DynamicallyQuantizedLinearWeight class's new method.

Copy link

pytorch-bot bot commented Sep 10, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/860

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8490581 with merge base 3e9746c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link

Hi @YihengBrianWu!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 10, 2024
@jerryzh168
Copy link
Contributor

thanks for the fix! for context we are deprecating this subclass actually, are you using this anywhere?

@YihengBrianWu
Copy link
Contributor Author

I'm just testing Int8DynamicallyQuantizedLinearWeight this class and find this typo. Any upragde on this class?

@msaroufim msaroufim merged commit 3ac2ab8 into pytorch:main Sep 10, 2024
17 checks passed
@YihengBrianWu YihengBrianWu deleted the wyh/fix_typo branch September 10, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants