add CI to disallow syntax errors and undefined vars in all Python files #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds two codebase-wide checks for Python files: 1. syntax errors (E999) 2. undefined variables (F821) Both of these resulted in internal breakages recently, so would be good to just have CI block these from landing in OSS. Test Plan: Tested that the new rules pass locally: ``` ruff check --isolated --select E999,F821 ``` Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/861
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 45e986d with merge base 3e9746c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
msaroufim
approved these changes
Sep 10, 2024
jainapurva
pushed a commit
that referenced
this pull request
Sep 10, 2024
…es (#861) Summary: Adds two codebase-wide checks for Python files: 1. syntax errors (E999) 2. undefined variables (F821) Both of these resulted in internal breakages recently, so would be good to just have CI block these from landing in OSS. Test Plan: Tested that the new rules pass locally: ``` ruff check --isolated --select E999,F821 ``` Reviewers: Subscribers: Tasks: Tags:
yanbing-j
pushed a commit
to yanbing-j/ao
that referenced
this pull request
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adds two codebase-wide checks for Python files:
Both of these resulted in internal breakages recently, so would be good to just have CI block these from landing in OSS.
Test Plan:
Tested that the new rules pass locally:
Reviewers:
Subscribers:
Tasks:
Tags: