[ROCm] add rocm wheels #1477
Merged
[ROCm] add rocm wheels #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaily
reviewed
Apr 28, 2021
|
@micmelesse Let us know when this PR is ready. This looks like a good addition. |
jeffdaily
approved these changes
May 6, 2021
|
@michaelauli Can you rebase on the latest master, just in case? I fixed some of the macOS issues. |
malfet
approved these changes
May 6, 2021
|
Thank you for the change. PR looks good to me, but let's not merge it until we understand why those builds are failing. |
micmelesse
force-pushed
the
build_rocm_wheels
branch
from
f57b031 to
987506a
Compare
|
@mthrok I have rebased and force pushed. |
|
HI @micmelesse #1497 has been merged. Could you rebase ? |
micmelesse
force-pushed
the
build_rocm_wheels
branch
from
987506a to
437612c
Compare
use the term cu_version update pkg_helpers add docker wheel option update config yml add force_cuda option
micmelesse
force-pushed
the
build_rocm_wheels
branch
2 times, most recently
from
42a7fed to
23cf3fb
Compare
malfet
approved these changes
May 28, 2021
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
Co-authored-by: Teng Gao <tegao@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds wheels for rocm. It is based on this PR for pytorch vision(pytorch/vision#3575) that adds rocm wheels .
It works by creating a rocm version of the binary_linux_wheel build jobs that use pytorch/manylinux-rocm instead of manylinux-cuda102.