-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable audio build on Windows with CUDA #1787
Conversation
@mthrok without this, there's one error locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI is green
if(USE_CUDA) | ||
set(CMAKE_CXX_STANDARD 17) | ||
endif() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that wouldn't work when TorchAudio is compiled with CUDA-10.2, would it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would.
https://app.circleci.com/pipelines/github/pytorch/audio/7396/workflows/058b3c2c-8421-40c2-915c-a8441deac091/jobs/339245.
It's a Visual Studio Issue. I verified that another workaround is to downgrade the Visual Studio to 16.8.5 which PyTorch Builder is using.
But I think user experience might better that the user doesn't need to select the compiler with the specific version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The root cause is a regression in VS. microsoft/STL#2020
The deletion itself is as-intended. The option was removed because What I might have missed is to check if the extension The logic there is that;
I am not sure what's the right fix for Windows, but one way it might work is to set the extension of |
Thanks @mthrok . It works now. I've submitted another PR #1788 for these change. |
…improveMakelist
Fixed link and note
With this PR, audio could be build on Windows with CUDA now.
It's from #1777
I've verified it locally.