Add wrapper classes that manage memories allocated by ffmpeg #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mthrok has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Closed
|
@mthrok has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mthrok
force-pushed
the
ffmpeg-wrapper
branch
from
fdbb573
to
014b111
Compare
carolineechen
approved these changes
Dec 7, 2021
|
@mthrok has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 8, 2021
Summary: Part of #1986. Splitting the PR for easier review. Add `Decoder` class that manages `AVCodecContext` resource and process input `AVPacket`. For the overall architecture, see https://github.com/mthrok/audio/blob/ffmpeg/torchaudio/csrc/ffmpeg/README.md. Note: Without a change to build process, the code added here won't be compiled. The build process will be updated later. Needs to be imported after #2041. Pull Request resolved: #2042 Reviewed By: carolineechen Differential Revision: D32933294 Pulled By: mthrok fbshipit-source-id: e443debadb44d491462fb641cd5b7b20c413b5b9
30 tasks
xiaohui-zhang
pushed a commit
to xiaohui-zhang/audio
that referenced
this pull request
May 4, 2022
…#2041) Summary: Part of pytorch#1986. Splitting the PR for easier review. Add wrapper classes that auto release memories allocated by ffmpeg libraries. For the overall architecture, see https://github.com/mthrok/audio/blob/ffmpeg/torchaudio/csrc/ffmpeg/README.md. Note: Without a change to build process, the code added here won't be compiled. The build process will be updated later. - [x] Needs to be imported after updating TARGETS file. Pull Request resolved: pytorch#2041 Reviewed By: carolineechen Differential Revision: D32688964 Pulled By: mthrok fbshipit-source-id: 165bef5b292dbedae4e9599d53fb2a3f06978db8
xiaohui-zhang
pushed a commit
to xiaohui-zhang/audio
that referenced
this pull request
May 4, 2022
Summary: Part of pytorch#1986. Splitting the PR for easier review. Add `Decoder` class that manages `AVCodecContext` resource and process input `AVPacket`. For the overall architecture, see https://github.com/mthrok/audio/blob/ffmpeg/torchaudio/csrc/ffmpeg/README.md. Note: Without a change to build process, the code added here won't be compiled. The build process will be updated later. Needs to be imported after pytorch#2041. Pull Request resolved: pytorch#2042 Reviewed By: carolineechen Differential Revision: D32933294 Pulled By: mthrok fbshipit-source-id: e443debadb44d491462fb641cd5b7b20c413b5b9
mthrok
pushed a commit
to mthrok/audio
that referenced
this pull request
Dec 13, 2022
Co-authored-by: Svetlana Karslioglu <svekars@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1986. Splitting the PR for easier review.
Add wrapper classes that auto release memories allocated by ffmpeg libraries.
For the overall architecture, see https://github.com/mthrok/audio/blob/ffmpeg/torchaudio/csrc/ffmpeg/README.md.
Note: Without a change to build process, the code added here won't be compiled. The build process will be updated later.