Update HW decoding tutorial and add notes about unseekable object #2408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
nateanl
reviewed
May 25, 2022
torchaudio/csrc/ffmpeg/streamer.cpp
Outdated
| "Failed to detect the source stream format. Please provide the decoder to use."); | ||
| std::ostringstream msg; | ||
| msg << "Failed to detect the source stream format. " | ||
| << "The media is not supported. "; |
There was a problem hiding this comment.
Suggested change
| << "The media is not supported. "; | |
| << "The media is not supported."; |
mthrok
force-pushed
the
fix-decoder
branch
2 times, most recently
from
d2505b3
to
5a65808
Compare
1. Update HW decoding tutorial to include file-like object 3. Add note about unseekable object int streaming API tutorial
hwangjeff
approved these changes
Jun 7, 2022
Co-authored-by: hwangjeff <hwangjeff@users.noreply.github.com>
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hey @mthrok. |
mthrok
added a commit
that referenced
this pull request
Jun 8, 2022
) Summary: https://output.circle-artifacts.com/output/job/75187a52-b0d8-4cac-89f3-24e10889a36a/artifacts/0/docs/hw_acceleration_tutorial.html 1. Update HW decoding tutorial to include file-like object 1. Add note about unseekable object int streaming API tutorial Pull Request resolved: #2408 Reviewed By: hwangjeff Differential Revision: D36632702 Pulled By: mthrok fbshipit-source-id: 17be2fb8528cb1d2d1ee11901b6a95c512466feb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://output.circle-artifacts.com/output/job/75187a52-b0d8-4cac-89f3-24e10889a36a/artifacts/0/docs/hw_acceleration_tutorial.html