Add metadata to source stream info #2461
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jun 7, 2022
Summary: Add metadata, such as ID3 (pytorch@da3ffe9bf146c89585ed32aaf3be7f81bea2c4ab)tag to `StreamReaderSourceAudioStream`. Pull Request resolved: pytorch#2461 Differential Revision: D36985656 Pulled By: mthrok fbshipit-source-id: 8a8fc6fda5c39c84f5a2fe10237f0eb793c968a6
|
This pull request was exported from Phabricator. Differential Revision: D36985656 |
hwangjeff
approved these changes
Jun 7, 2022
Summary: Add metadata, such as ID3 (pytorch@a5a7849ae86caad70a788130b03a594daf4eea0b)tag to `StreamReaderSourceAudioStream`. Pull Request resolved: pytorch#2461 Reviewed By: hwangjeff Differential Revision: D36985656 Pulled By: mthrok fbshipit-source-id: b63f48a22b70627c2e5b8e4e6b81849ca67d5bc7
|
This pull request was exported from Phabricator. Differential Revision: D36985656 |
|
Hey @mthrok. |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jun 8, 2022
This reverts commit 10d1bd8.
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jun 8, 2022
In pytorch#2461, `metadata` field was added to StreamInfo. However, the value attached to this new field was source-level metadata, while each stream can have different metadata. * source level metadata [AVFormatContext->metadata](https://ffmpeg.org/doxygen/4.1/structAVFormatContext.html#a3019a56080ed2e3297ff25bc2ff88adf) * stream level metadata [AVFormatContext->streams[]->metadata](https://ffmpeg.org/doxygen/4.1/structAVStream.html#a50d250a128a3da9ce3d135e84213fb82) This commit moves source level metadata to dedicated method, and revert the changes made on StreamInfomation in pytorch#2461.
Closed
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Jun 8, 2022
In pytorch#2461, `metadata` field was added to StreamInfo. However, the value attached to this new field was source-level metadata, while each stream can have different metadata. * source level metadata [AVFormatContext->metadata](https://ffmpeg.org/doxygen/4.1/structAVFormatContext.html#a3019a56080ed2e3297ff25bc2ff88adf) * stream level metadata [AVFormatContext->streams[]->metadata](https://ffmpeg.org/doxygen/4.1/structAVStream.html#a50d250a128a3da9ce3d135e84213fb82) This commit moves source level metadata to dedicated method, `get_metadata`, and fix the stream-level metadata to report stream metadata.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 8, 2022
Summary: In #2461, `metadata` field was added to StreamInfo. However, the value attached to this new field was source-level metadata, while each stream can have different metadata. * source level metadata [AVFormatContext->metadata](https://ffmpeg.org/doxygen/4.1/structAVFormatContext.html#a3019a56080ed2e3297ff25bc2ff88adf) * stream level metadata [AVFormatContext->streams[]->metadata](https://ffmpeg.org/doxygen/4.1/structAVStream.html#a50d250a128a3da9ce3d135e84213fb82) This commit moves source level metadata to dedicated method, `get_metadata`, and fix the stream-level metadata to report stream metadata. Pull Request resolved: #2464 Reviewed By: hwangjeff, xiaohui-zhang Differential Revision: D36995452 Pulled By: mthrok fbshipit-source-id: 534be1f7feb07790a0ce8624c336cdb7b65a8697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add metadata, such as ID3tag to
StreamReaderSourceAudioStream.