Move helper functions out of common utility for better locality #2512
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits move helper functions/definitions around so that better locality of logics are achieved.
Detail
ffmpeg.[h|cpp]
implements classes that convert FFmpeg structures into RAII semantics.Initially it these classes included the construction logic in their constructors, but such logics were
extracted to factory functions in #2373.
Now the reason why the factory functions stayed in
ffmpeg.[h|cpp]
was because the logic forthe initialization and clean-up of AVDictionary class was only available in
ffmpeg.cpp
.Now AVDictionary class handling is properly defined in #2507, the factory functions, which are not
that reusable better stay with the implementation that use them.
This makes
ffmpeg.h
lean and clean, makes it easier to see what can be reused.