-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support compression level in i/o dispatcher backend #3662
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/3662
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2192ce6 with merge base 671261c (): This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D50367721 |
src/torchaudio/_backend/ffmpeg.py
Outdated
@@ -304,7 +306,13 @@ def save( | |||
encoding: Optional[str] = None, | |||
bits_per_sample: Optional[int] = None, | |||
buffer_size: int = 4096, | |||
compression: Optional[Union[torchaudio.io.CodecConfig, int]] = None, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that the compression type for sox should be float.
https://sox.sourceforge.net/soxformat.html
In order to squeeze the selection of VBR into the the −C value float we use negative numbers to select VRR. -4.2 would select default VBR encoding (size) with high quality (speed). One special case is 0, which is a valid VBR encoding parameter but not a valid bitrate. Compression value of 0 is always treated as a high quality vbr, as a result both -0.2 and 0.2 are treated as highest quality VBR (size) and high quality (speed).
Summary: Pull Request resolved: pytorch#3662 Differential Revision: D50367721
e7a208d
to
0c4f76c
Compare
This pull request was exported from Phabricator. Differential Revision: D50367721 |
Summary: Pull Request resolved: pytorch#3662 Differential Revision: D50367721
0c4f76c
to
3972fbe
Compare
This pull request was exported from Phabricator. Differential Revision: D50367721 |
Summary: Pull Request resolved: pytorch#3662 Differential Revision: D50367721
3972fbe
to
0883323
Compare
This pull request was exported from Phabricator. Differential Revision: D50367721 |
1 similar comment
This pull request was exported from Phabricator. Differential Revision: D50367721 |
Summary: Pull Request resolved: pytorch#3662 Differential Revision: D50367721 fbshipit-source-id: fbb6d62a6bdf6a55c98a8e94d08e344b8377f1dc
0883323
to
025314e
Compare
Summary: Pull Request resolved: pytorch#3662 Differential Revision: D50367721
025314e
to
2192ce6
Compare
This pull request was exported from Phabricator. Differential Revision: D50367721 |
Hey @None. Some guidance:Use 'module: ops' for operations under 'torchaudio/{transforms, functional}', and ML-related components under 'torchaudio/csrc' (e.g. RNN-T loss). Things in "examples" directory:
Regarding examples in code documentations, please also use 'module: docs'. Please use 'other' tag only when you’re sure the changes are not much relevant to users, or when all other tags are not applicable. Try not to use it often, in order to minimize efforts required when we prepare release notes. When preparing release notes, please make sure 'documentation' and 'tutorials' occur as the last sub-categories under each primary category like 'new feature', 'improvements' or 'prototype'. Things related to build are by default excluded from the release note, except when it impacts users. For example: |
Differential Revision: D50367721 Pull Request resolved: pytorch#3662
Differential Revision: D50367721 Pull Request resolved: pytorch#3662
Differential Revision: D50367721 Pull Request resolved: #3662
Differential Revision: D50367721