-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backends] List models function call replacement #1821
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
BTW, we tested the running the userbenchmark at: https://github.com/pytorch/benchmark/actions/runs/5833882739 Unfortunately, the workflow failed because we currently don't have tensorrt or torch_trt installed in our nightly docker. |
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Hi @xuzhao9 - thanks for the reference! I looked into the Dockerfile and there's a few considerations we'll need to address on the Torch-TRT side to ensure the testing will work. I have a few questions to address this:
This will help me to understand the requirements to provide a nightly build of Torch-TRT which will be compatible with the versions in the container. |
@gs-olive
|
Thank you for the detailed answers, this is very helpful. We are working on publishing nightly releases of Torch-TRT via Github Actions and I will update the Dockerfile as soon as those are ready. |
_list_model_paths
call withlist_models