Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backends] List models function call replacement #1821

Closed
wants to merge 1 commit into from

Conversation

gs-olive
Copy link
Contributor

  • Replace _list_model_paths call with list_models

Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@xuzhao9
Copy link
Contributor

xuzhao9 commented Aug 13, 2023

BTW, we tested the running the userbenchmark at: https://github.com/pytorch/benchmark/actions/runs/5833882739

Unfortunately, the workflow failed because we currently don't have tensorrt or torch_trt installed in our nightly docker.
Can you please help fix our docker file? https://github.com/pytorch/benchmark/blob/main/docker/torchbench-nightly.dockerfile

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 030fdbd.

@gs-olive
Copy link
Contributor Author

gs-olive commented Aug 16, 2023

Hi @xuzhao9 - thanks for the reference! I looked into the Dockerfile and there's a few considerations we'll need to address on the Torch-TRT side to ensure the testing will work. I have a few questions to address this:

  1. At what time is the nightly CI run?
  2. What Python and CUDA versions does the Docker container use?
  3. Does the Docker container use the latest-available Torch nightly?

This will help me to understand the requirements to provide a nightly build of Torch-TRT which will be compatible with the versions in the container.

@xuzhao9
Copy link
Contributor

xuzhao9 commented Aug 18, 2023

@gs-olive
See my answers below:

  1. The nightly CI will run everyday at 4PM UTC (https://github.com/pytorch/benchmark/blob/main/.github/workflows/userbenchmark-a100.yml#L4) after the latest nightly docker is built.
  2. The default Python and CUDA versions are defined at https://github.com/pytorch/benchmark/blob/main/utils/cuda_utils.py#L11 and https://github.com/pytorch/benchmark/blob/main/utils/python_utils.py#L4, respectively. It is easy to upgrade them and follow the recommendation of the latest pytorch nightly build.
  3. Yes, the Docker container uses the latest-available Torch nightly release, we will update the Docker everyday at https://github.com/pytorch/benchmark/actions/workflows/build-nightly-docker.yml

@gs-olive
Copy link
Contributor Author

Thank you for the detailed answers, this is very helpful. We are working on publishing nightly releases of Torch-TRT via Github Actions and I will update the Dockerfile as soon as those are ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants