Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Python 3.11 as the default version. #1889

Closed
wants to merge 9 commits into from
Closed

Enable Python 3.11 as the default version. #1889

wants to merge 9 commits into from

Conversation

xuzhao9
Copy link
Contributor

@xuzhao9 xuzhao9 commented Sep 11, 2023 •
edited
Loading

@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload September 11, 2023 17:32 — with GitHub Actions Inactive
@msaroufim
Copy link
Member

mask_r_cnn started to crash for me on my other PRs as well, this model has been giving me issues for as far as i can remember iwouldnt mind a skip

@msaroufim msaroufim self-requested a review September 12, 2023 00:21
@xuzhao9
Copy link
Contributor Author

xuzhao9 commented Sep 12, 2023

mask_r_cnn started to crash for me on my other PRs as well, this model has been giving me issues for as far as i can remember iwouldnt mind a skip

Strangely it only crashes on A10G, not A100. Perhaps there is something special about A10G? cc @malfet

@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload September 28, 2023 16:42 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload September 28, 2023 16:43 — with GitHub Actions Inactive
@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload September 28, 2023 17:37 — with GitHub Actions Inactive
@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload September 28, 2023 21:03 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 temporarily deployed to docker-s3-upload September 28, 2023 21:03 — with GitHub Actions Inactive
@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 106d14a.

@xuzhao9 xuzhao9 deleted the xz9/upgrade-311 branch September 28, 2023 23:51
sallyseok pushed a commit to sallyseok/benchmark that referenced this pull request Sep 29, 2023
@xuzhao9 @sallyseok
Enable Python 3.11 as the default version. (pytorch#1889)
92e2381 
Summary:
Fixes pytorch#1885

Test workflow: https://github.com/pytorch/benchmark/actions/runs/6344156015

Pull Request resolved: pytorch#1889

Reviewed By: davidberard98, msaroufim

Differential Revision: D49739127

Pulled By: xuzhao9

fbshipit-source-id: 4bf96d89396bdc599c02af56b5e684b2f1e8f200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msaroufim msaroufim msaroufim approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to Python 3.11
3 participants
@xuzhao9 @msaroufim @facebook-github-bot