Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .cuda() from cm3leon's model.py #1897

Closed
wants to merge 1 commit into from

Conversation

hmellor
Copy link
Contributor

@hmellor hmellor commented Sep 14, 2023

Also remove the .eval() as the .eval() and the moving to device is done immediately afterward in the model's __init__.py

Also remove the `.eval()` as the `.eval()` and the moving to device is done
immediately afterward in the model's `__init__.py`
@hmellor hmellor temporarily deployed to docker-s3-upload September 14, 2023 13:39 — with GitHub Actions Inactive
@xuzhao9 xuzhao9 requested review from ezyang and msaroufim September 14, 2023 15:21
@hmellor
Copy link
Contributor Author

hmellor commented Sep 14, 2023

The failure in TorchBench PR Test seems to be unrelated to my change

@xuzhao9
Copy link
Contributor

xuzhao9 commented Sep 14, 2023

@hmellor Yes, just fixed in e1b51f5. The PR looks good to me.

Copy link
Contributor

@xuzhao9 xuzhao9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in 6532c61.

@hmellor hmellor deleted the generalise-cm3leon-generate branch September 26, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants