Rename the enable_fp16_half() function to enable_fp16
#1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuzhao9
force-pushed
the
xz9/add-hf-dynamic
branch
from
ce932ef to
ffe2f90
Compare
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Failure
chuanqi129
approved these changes
Sep 17, 2023
xuzhao9
force-pushed
the
xz9/add-hf-dynamic
branch
from
ada4c76 to
35c6581
Compare
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
had a problem deploying
to
docker-s3-upload
GitHub Actions
Error
xuzhao9
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
xuzhao9
temporarily deployed
to
docker-s3-upload
GitHub Actions
Inactive
|
@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are renaming
enable_fp16_half()toenable_fp16()because the amp fp16 is now namedenable_amp_fp16(). This makes the naming of dargs-related functions cleaner.It also implements the enable_fp16, enable_bf16, and enable_channels_last in a cleaner by utilizing the common
inputs_castfunction.