Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not skip llama_v2_7b_16h on NVIDIA A100 40G. #2124

Closed
wants to merge 1 commit into from

Conversation

ysiraichi
Copy link
Contributor

This PR partially reverts #2095, since #2064 seems not to be an issue anymore.

@xuzhao9
Copy link
Contributor

xuzhao9 commented Jan 22, 2024

This will require another fix: #2123

@ysiraichi
Copy link
Contributor Author

Does it? I ran the command in #2064 with an A100, and it seems to pass. Is there anything I'm missing?

@xuzhao9
Copy link
Contributor

xuzhao9 commented Jan 22, 2024

Does it? I ran the command in #2064 with an A100, and it seems to pass. Is there anything I'm missing?

Yes, there is a bug in our A10G workflow specific to our CI environment, and #2123 fixes it.

@ysiraichi ysiraichi force-pushed the fix-llama2-metadata branch from d91d035 to 0d6b835 Compare January 24, 2024 13:09
@ysiraichi
Copy link
Contributor Author

@xuzhao9 Can we merge this, now that #2123 was merged?

@facebook-github-bot
Copy link
Contributor

@xuzhao9 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@xuzhao9
Copy link
Contributor

xuzhao9 commented Jan 25, 2024

@ysiraichi LGTM, working on the merge now.

@facebook-github-bot
Copy link
Contributor

@xuzhao9 merged this pull request in c6e2004.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants