Apply PEP 604 union type syntax codemod #2561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2561 +/- ##
==========================================
- Coverage 99.98% 99.98% -0.01%
==========================================
Files 193 193
Lines 17111 17071 -40
==========================================
- Hits 17108 17068 -40
Misses 3 3 ☔ View full report in Codecov by Sentry. |
Balandat
force-pushed
the
pep604
branch
3 times, most recently
from
f2860e5 to
4cbda31
Compare
|
@Balandat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was exported from Phabricator. Differential Revision: D63733395 |
Balandat
added a commit
to Balandat/botorch
that referenced
this pull request
Oct 2, 2024
Summary: This codemods all `Optional[X]` type definitions to use the PEP 604 syntax `X | None` instead. I also ran ufmt to fix the imports. Why? I came across https://github.com/asottile/pyupgrade randomly and figured I'd give it a shot... This is mostly to test that everything runs smoothly. This may be kind of a pain to rebase on so not sure we should merge this in in one big chunk... Pull Request resolved: pytorch#2561 Reviewed By: esantorella Differential Revision: D63733395 Pulled By: Balandat
Summary: This codemods all `Optional[X]` type definitions to use the PEP 604 syntax `X | None` instead. I also ran ufmt to fix the imports. Why? I came across https://github.com/asottile/pyupgrade randomly and figured I'd give it a shot... This is mostly to test that everything runs smoothly. This may be kind of a pain to rebase on so not sure we should merge this in in one big chunk... Pull Request resolved: pytorch#2561 Reviewed By: esantorella Differential Revision: D63733395 Pulled By: Balandat
|
This pull request was exported from Phabricator. Differential Revision: D63733395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This codemods all
Optional[X]type definitions to use the PEP 604 syntaxX | Noneinstead.