Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper for evaluating feasibility of a set of points #2565

Closed
wants to merge 1 commit into from

Conversation

saitcakmak
Copy link
Contributor

Summary: Adds a helper for evaluating the feasibility of intra-point parameter constraints on a given tensor.

Differential Revision: D63909338

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 4, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63909338

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (df93789) to head (a546b5e).
Report is 91 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2565   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         195      195           
  Lines       17112    17131   +19     
=======================================
+ Hits        17109    17128   +19     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

)

Summary:

Adds a helper for evaluating the feasibility of intra-point parameter constraints on a given tensor.

Differential Revision: D63909338
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D63909338

@saitcakmak saitcakmak closed this Jan 31, 2025
saitcakmak added a commit to saitcakmak/botorch that referenced this pull request Feb 6, 2025
…2565)

Summary:

Adds a helper for evaluating the feasibility of parameter constraints on a `batch x q x d` tensor of candidates.

A follow-up diff will utilize this to detect infeasible candidates produced during optimization and raise an error rather than returning infeasible points to the user.

Differential Revision: D63909338
facebook-github-bot pushed a commit that referenced this pull request Feb 7, 2025
Summary:
Pull Request resolved: #2733

Pull Request resolved: #2565

Adds a helper for evaluating the feasibility of parameter constraints on a `batch x q x d` tensor of candidates.

A follow-up diff will utilize this to detect infeasible candidates produced during optimization and raise an error rather than returning infeasible points to the user.

Reviewed By: esantorella

Differential Revision: D63909338

fbshipit-source-id: 873ba5036a7076b718ec5e3f054b6f0f3fb999c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants