Check for feasibility in gen_candidates_scipy and error out for infeasible candidates #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69314159 |
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2737 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 203 203
Lines 18691 18689 -2
=======================================
- Hits 18690 18688 -2
Misses 1 1 ☔ View full report in Codecov by Sentry. |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Feb 7, 2025
…sible candidates (pytorch#2737) Summary: As titled. Previously, it was possible to return infeasible candidates to the user, with or without warnings alerting the user to the issue. This diff makes it so that the optimizer will error out when infeasible candidates are generated, so that the user can adjust the setup as needed. Resolves pytorch#2708 Also includes a couple lint fixes in optimizer tests. Differential Revision: D69314159
saitcakmak
force-pushed
the
export-D69314159
branch
from
24dc091 to
6373914
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69314159 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Feb 7, 2025
…sible candidates (pytorch#2737) Summary: As titled. Previously, it was possible to return infeasible candidates to the user, with or without warnings alerting the user to the issue. This diff makes it so that the optimizer will error out when infeasible candidates are generated, so that the user can adjust the setup as needed. Resolves pytorch#2708 Also includes a couple lint fixes in optimizer tests. Differential Revision: D69314159
saitcakmak
force-pushed
the
export-D69314159
branch
from
6373914 to
0320224
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69314159 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Feb 7, 2025
…sible candidates (pytorch#2737) Summary: As titled. Previously, it was possible to return infeasible candidates to the user, with or without warnings alerting the user to the issue. This diff makes it so that the optimizer will error out when infeasible candidates are generated, so that the user can adjust the setup as needed. Resolves pytorch#2708 Also includes a couple lint fixes in optimizer tests. Reviewed By: esantorella Differential Revision: D69314159
saitcakmak
force-pushed
the
export-D69314159
branch
from
0320224 to
1dc3435
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69314159 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Feb 7, 2025
…sible candidates (pytorch#2737) Summary: As titled. Previously, it was possible to return infeasible candidates to the user, with or without warnings alerting the user to the issue. This diff makes it so that the optimizer will error out when infeasible candidates are generated, so that the user can adjust the setup as needed. Resolves pytorch#2708 Also includes a couple lint fixes in optimizer tests. Reviewed By: esantorella Differential Revision: D69314159
saitcakmak
force-pushed
the
export-D69314159
branch
from
1dc3435 to
8e2a8c1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69314159 |
saitcakmak
added a commit
to saitcakmak/botorch
that referenced
this pull request
Feb 7, 2025
…sible candidates (pytorch#2737) Summary: As titled. Previously, it was possible to return infeasible candidates to the user, with or without warnings alerting the user to the issue. This diff makes it so that the optimizer will error out when infeasible candidates are generated, so that the user can adjust the setup as needed. Resolves pytorch#2708 Also includes a couple lint fixes in optimizer tests. Reviewed By: esantorella Differential Revision: D69314159
saitcakmak
force-pushed
the
export-D69314159
branch
from
8e2a8c1 to
8dc4d98
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69314159 |
…sible candidates (pytorch#2737) Summary: As titled. Previously, it was possible to return infeasible candidates to the user, with or without warnings alerting the user to the issue. This diff makes it so that the optimizer will error out when infeasible candidates are generated, so that the user can adjust the setup as needed. Resolves pytorch#2708 Also includes a couple lint fixes in optimizer tests. Reviewed By: esantorella Differential Revision: D69314159
saitcakmak
force-pushed
the
export-D69314159
branch
from
8dc4d98 to
bf9a56b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69314159 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Feb 8, 2025
…sible candidates Summary: X-link: pytorch/botorch#2737 As titled. Previously, it was possible to return infeasible candidates to the user, with or without warnings alerting the user to the issue. This diff makes it so that the optimizer will error out when infeasible candidates are generated, so that the user can adjust the setup as needed. Resolves pytorch/botorch#2708 Also includes a couple lint fixes in optimizer tests. Reviewed By: esantorella Differential Revision: D69314159
|
This pull request has been merged in 104df60. |
facebook-github-bot
pushed a commit
to facebook/Ax
that referenced
this pull request
Feb 8, 2025
…sible candidates (#3335) Summary: Pull Request resolved: #3335 X-link: pytorch/botorch#2737 As titled. Previously, it was possible to return infeasible candidates to the user, with or without warnings alerting the user to the issue. This diff makes it so that the optimizer will error out when infeasible candidates are generated, so that the user can adjust the setup as needed. Resolves pytorch/botorch#2708 Also includes a couple lint fixes in optimizer tests. Reviewed By: esantorella Differential Revision: D69314159 fbshipit-source-id: ccbc759274b2ae0fc2b38fa19d0e95abf35a2928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As titled. Previously, it was possible to return infeasible candidates to the user, with or without warnings alerting the user to the issue. This diff makes it so that the optimizer will error out when infeasible candidates are generated, so that the user can adjust the setup as needed.
Resolves #2708
Also includes a couple lint fixes in optimizer tests.
Differential Revision: D69314159