Modifying smoke test to add more advanced validation as requested (#1124

)

* Modify smoke test matrix

More vision smoke tests

Temporary pointing to my repo for testing

Try 2 use atalman builder

Modify path

Fixing commits

Testing

Testing

Smoke test modifications

Refactor test code

Fix typo

Fixing image read

A little more refactoring

Addressing comments

Testing

* Add same test for windows and macos

* Addressing c omments

.github/workflows/validate-linux-binaries.yml

@@ -6,9 +6,11 @@ on:
       main
     paths:
       - .github/workflows/validate-linux-binaries.yml
+      - .test/smoke_test/*
   pull_request:
     paths:
       - .github/workflows/validate-linux-binaries.yml
+      - .test/smoke_test/*
 jobs:
   generate-conda-matrix:
     uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main
@@ -28,6 +30,8 @@ jobs:
       package-type: libtorch
       os: linux
       channel: nightly
+
+
   validate-linux-binaries-conda:
     needs: generate-conda-matrix
     strategy:

.github/workflows/validate-macos-binaries.yml

@@ -4,6 +4,7 @@ on:
   pull_request:
     paths:
       - .github/workflows/validate-macos-binaries.yml
+      - .test/smoke_test/*
 jobs:
   generate-arm64-conda-matrix:
     uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main

.github/workflows/validate-windows-binaries.yml

@@ -6,9 +6,11 @@ on:
       main
     paths:
       - .github/workflows/validate-windows-binaries.yml
+      - .test/smoke_test/*
   pull_request:
     paths:
       - .github/workflows/validate-windows-binaries.yml
+      - .test/smoke_test/*
 jobs:
   generate-conda-matrix:
     uses: pytorch/test-infra/.github/workflows/generate_binary_build_matrix.yml@main

test/smoke_test/smoke_test.py

@@ -3,28 +3,80 @@
 import torch
 import torchvision
 import torchaudio
+from pathlib import Path
 
-def smoke_test_cuda() -> None:
-    gpu_arch_ver = os.getenv('GPU_ARCH_VER')
-    gpu_arch_type = os.getenv('GPU_ARCH_TYPE')
-    is_cuda_system = gpu_arch_type == "cuda"
+gpu_arch_ver = os.getenv("GPU_ARCH_VER")
+gpu_arch_type = os.getenv("GPU_ARCH_TYPE")
+is_cuda_system = gpu_arch_type == "cuda"
+SCRIPT_DIR = Path(__file__).parent
 
+def smoke_test_cuda() -> None:
     if(not torch.cuda.is_available() and is_cuda_system):
-        print(f"Expected CUDA {gpu_arch_ver}. However CUDA is not loaded.")
-        sys.exit(1)
+        raise RuntimeError(f"Expected CUDA {gpu_arch_ver}. However CUDA is not loaded.")
     if(torch.cuda.is_available()):
         if(torch.version.cuda != gpu_arch_ver):
-            print(f"Wrong CUDA version. Loaded: {torch.version.cuda} Expected: {gpu_arch_ver}")
-            sys.exit(1)
-        y=torch.randn([3,5]).cuda()
+            raise RuntimeError(f"Wrong CUDA version. Loaded: {torch.version.cuda} Expected: {gpu_arch_ver}")
         print(f"torch cuda: {torch.version.cuda}")
-        #todo add cudnn version validation
+        # todo add cudnn version validation
         print(f"torch cudnn: {torch.backends.cudnn.version()}")
 
+def smoke_test_conv2d() -> None:
+    import torch.nn as nn
+    print("Calling smoke_test_conv2d")
+    # With square kernels and equal stride
+    m = nn.Conv2d(16, 33, 3, stride=2)
+    # non-square kernels and unequal stride and with padding
+    m = nn.Conv2d(16, 33, (3, 5), stride=(2, 1), padding=(4, 2))
+    # non-square kernels and unequal stride and with padding and dilation
+    m = nn.Conv2d(16, 33, (3, 5), stride=(2, 1), padding=(4, 2), dilation=(3, 1))
+    input = torch.randn(20, 16, 50, 100)
+    output = m(input)
+    if(is_cuda_system):
+        print("Testing smoke_test_conv2d with cuda")
+        conv = nn.Conv2d(3, 3, 3).cuda()
+        x = torch.randn(1, 3, 24, 24).cuda()
+        with torch.cuda.amp.autocast():
+            out = conv(x)
+
 def smoke_test_torchvision() -> None:
-    import torchvision.datasets as dset
-    import torchvision.transforms
-    print('Is torchvision useable?', all(x is not None for x in [torch.ops.image.decode_png, torch.ops.torchvision.roi_align]))
+    print("Is torchvision useable?", all(x is not None for x in [torch.ops.image.decode_png, torch.ops.torchvision.roi_align]))
+
+def smoke_test_torchvision_read_decode() -> None:
+    from torchvision.io import read_image
+    img_jpg = read_image(str(SCRIPT_DIR / "assets" / "rgb_pytorch.jpg"))
+    if img_jpg.ndim != 3 or img_jpg.numel() < 100:
+      raise RuntimeError(f"Unexpected shape of img_jpg: {img_jpg.shape}")
+    img_png = read_image(str(SCRIPT_DIR  / "assets" / "rgb_pytorch.png"))
+    if img_png.ndim != 3 or img_png.numel() < 100:
+      raise RuntimeError(f"Unexpected shape of img_png: {img_png.shape}")
+
+def smoke_test_torchvision_resnet50_classify() -> None:
+    from torchvision.io import read_image
+    from torchvision.models import resnet50, ResNet50_Weights
+
+    img = read_image(str(SCRIPT_DIR / "assets" / "dog2.jpg"))
+
+    # Step 1: Initialize model with the best available weights
+    weights = ResNet50_Weights.DEFAULT
+    model = resnet50(weights=weights)
+    model.eval()
+
+    # Step 2: Initialize the inference transforms
+    preprocess = weights.transforms()
+
+    # Step 3: Apply inference preprocessing transforms
+    batch = preprocess(img).unsqueeze(0)
+
+    # Step 4: Use the model and print the predicted category
+    prediction = model(batch).squeeze(0).softmax(0)
+    class_id = prediction.argmax().item()
+    score = prediction[class_id].item()
+    category_name = weights.meta["categories"][class_id]
+    expected_category = "German shepherd"
+    print(f"{category_name}: {100 * score:.1f}%")
+    if(category_name != expected_category):
+        raise RuntimeError(f"Failed ResNet50 classify {category_name} Expected: {expected_category}")
+
 
 def smoke_test_torchaudio() -> None:
     import torchaudio.compliance.kaldi  # noqa: F401
@@ -36,14 +88,18 @@ def smoke_test_torchaudio() -> None:
     import torchaudio.transforms  # noqa: F401
     import torchaudio.utils  # noqa: F401
 
+
 def main() -> None:
     #todo add torch, torchvision and torchaudio tests
     print(f"torch: {torch.__version__}")
     print(f"torchvision: {torchvision.__version__}")
     print(f"torchaudio: {torchaudio.__version__}")
     smoke_test_cuda()
-    smoke_test_torchvision()
+    smoke_test_conv2d()
     smoke_test_torchaudio()
+    smoke_test_torchvision()
+    smoke_test_torchvision_read_decode()
+    smoke_test_torchvision_resnet50_classify()
 
 if __name__ == "__main__":
     main()