Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux validation binaries (conda, wheel, libtorch) #1117

Merged
merged 17 commits into from
Sep 1, 2022

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Aug 31, 2022

Linux binaries validation download miniconda, create conda env, install pytorch, and do import pytorch.
Similar to: #1102

@atalman atalman changed the title Linux validation binaries (conda, wheel, libtorch) [WIP] Linux validation binaries (conda, wheel, libtorch) Aug 31, 2022
@atalman atalman changed the title [WIP] Linux validation binaries (conda, wheel, libtorch) Linux validation binaries (conda, wheel, libtorch) Aug 31, 2022
@malfet
Copy link
Contributor

malfet commented Aug 31, 2022

Lots of CUDA failures seems to stem from a the fact, that you are failing to pass --pre argument and therefore install binaries released to pypi rather than nightly builds.
And the fact that you are passing 10.2 and cpu tests means that you do not check the version of the installed binaries.

@atalman
Copy link
Contributor Author

atalman commented Aug 31, 2022

hat you are failing to pass --pre argument and therefore install binaries released to pypi rather than nightly builds.
And the fact that you are passing 10.2 and cpu tests means that y

Thank you @malfet will fix it!

@atalman atalman force-pushed the release_validation_linux branch 5 times, most recently from 28f1fcb to 8c07e72 Compare September 1, 2022 19:48
Copy link
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@weiwangmeta weiwangmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@atalman atalman merged commit 03c4b2e into pytorch:main Sep 1, 2022
@malfet
Copy link
Contributor

malfet commented Sep 1, 2022

Why you've merged the job with so many failures? Were they all legitimate?

@atalman
Copy link
Contributor Author

atalman commented Sep 6, 2022

@malfet Rerunning the workflow, only 3.11 wheels are failing, which are expected:
https://github.com/pytorch/builder/runs/8207224963?check_suite_focus=true

We will have to add an ignore for 3.11 python builds for now or something like yhis.
As you can see the build PR has the same issue now: pytorch/test-infra#640
We probably want to exclude all 3.11 builds for now in matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants