Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aarch64 changes for PyTorch release 2.0 #1336

Merged
merged 4 commits into from
Mar 8, 2023
Merged

Aarch64 changes for PyTorch release 2.0 #1336

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0ed5ae
Aarch64 changes for PyTorch release 2.0
atalman Mar 8, 2023
4ba2bb0
Fix spacing
atalman Mar 8, 2023
7e3d105
Update aarch64_linux/build_aarch64_wheel.py
atalman Mar 8, 2023
d4728e2
Update aarch64_linux/build_aarch64_wheel.py
atalman Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions aarch64_linux/build_aarch64_wheel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@ def build_torchvision(host: RemoteHost, *,
"v1.12.1": ("0.13.1", "rc6"),
"v1.13.0": ("0.14.0", "rc4"),
"v1.13.1": ("0.14.1", "rc2"),
"v2.0.0": ("0.15.0", "rc6"),
})
print('Building TorchVision wheel')
build_vars = ""
Expand Down Expand Up @@ -333,6 +334,7 @@ def build_torchdata(host: RemoteHost, *,
git_clone_flags=git_clone_flags,
mapping={
"v1.13.1": ("0.5.1", ""),
"v2.0.0": ("0.6.0", "rc4"),
})
print('Building TorchData wheel')
build_vars = ""
Expand Down Expand Up @@ -375,6 +377,7 @@ def build_torchtext(host: RemoteHost, *,
"v1.12.1": ("0.13.1", "rc5"),
"v1.13.0": ("0.14.0", "rc3"),
"v1.13.1": ("0.14.1", "rc1"),
"v2.0.0": ("0.15.0", "rc4"),
})
print('Building TorchText wheel')
build_vars = ""
Expand Down Expand Up @@ -417,6 +420,7 @@ def build_torchaudio(host: RemoteHost, *,
"v1.12.1": ("0.12.1", "rc5"),
"v1.13.0": ("0.13.0", "rc4"),
"v1.13.1": ("0.13.1", "rc2"),
"v2.0.0": ("2.0.0", "rc5"),
})
print('Building TorchAudio wheel')
build_vars = ""
Expand Down Expand Up @@ -515,7 +519,7 @@ def start_build(host: RemoteHost, *,
build_date = host.check_output("cd pytorch ; git log --pretty=format:%s -1").strip().split()[0].replace("-", "")
version = host.check_output("cat pytorch/version.txt").strip()[:-2]
build_vars += f"BUILD_TEST=0 PYTORCH_BUILD_VERSION={version}.dev{build_date} PYTORCH_BUILD_NUMBER=1"
if branch.startswith("v1."):
if branch.startswith("v"):
atalman marked this conversation as resolved.
Show resolved Hide resolved
build_vars += f"BUILD_TEST=0 PYTORCH_BUILD_VERSION={branch[1:branch.find('-')]} PYTORCH_BUILD_NUMBER=1"
if host.using_docker():
build_vars += " CMAKE_SHARED_LINKER_FLAGS=-Wl,-z,max-page-size=0x10000"
Expand Down Expand Up @@ -677,7 +681,7 @@ def parse_arguments():
parser.add_argument("--build-only", action="store_true")
parser.add_argument("--test-only", type=str)
parser.add_argument("--os", type=str, choices=list(os_amis.keys()), default='ubuntu18_04')
parser.add_argument("--python-version", type=str, choices=['3.6', '3.7', '3.8', '3.9', '3.10', '3.11'], default=None)
parser.add_argument("--python-version", type=str, choices=['3.8', '3.9', '3.10', '3.11'], default=None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really need to remove older versions (as the script is usable to build say PyTorch-1.10), but feel free to change the default

atalman marked this conversation as resolved.
Show resolved Hide resolved
parser.add_argument("--alloc-instance", action="store_true")
parser.add_argument("--list-instances", action="store_true")
parser.add_argument("--pytorch-only", action="store_true")
Expand Down