Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Upgrade cmake version to 3.22.1 to build triton (#1331)" #1351

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Revert "Upgrade cmake version to 3.22.1 to build triton (#1331)" #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d4082a3
Revert "Upgrade cmake version to 3.22.1 to build triton (#1331)"
huydhn Mar 13, 2023
ae962d6
Selective revert
huydhn Mar 13, 2023
9fb56e4
Get cmake from pip
huydhn Mar 13, 2023
7d4afe7
Use 3.18.2 from conda
huydhn Mar 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions common/install_conda.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ chmod +x Miniconda3-latest-Linux-x86_64.sh
bash ./Miniconda3-latest-Linux-x86_64.sh -b -p /opt/conda
rm Miniconda3-latest-Linux-x86_64.sh
export PATH=/opt/conda/bin:$PATH
# cmake-3.22.1 from conda, same as the one used by PyTorch CI. The system cmake
# is too old to build triton
conda install -y conda-build anaconda-client git ninja cmake=3.22.1
# The cmake version here needs to match with the minimum version of cmake
# supported by PyTorch (3.18). There is only 3.18.2 on anaconda
conda install -y conda-build anaconda-client git ninja cmake=3.18.2
conda remove -y --force patchelf
5 changes: 2 additions & 3 deletions manywheel/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,9 @@ RUN wget http://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm &
rpm -ivh epel-release-latest-7.noarch.rpm && \
rm -f epel-release-latest-7.noarch.rpm

# cmake-3.22.1 from pip, same as the one used by PyTorch CI. cmake-3.18.4 is
# too old to build triton now
# cmake-3.18.4 from pip
RUN yum install -y python3-pip && \
python3 -mpip install cmake==3.22.1 && \
python3 -mpip install cmake==3.18.4 && \
ln -s /usr/local/bin/cmake /usr/bin/cmake

RUN yum install -y autoconf aclocal automake make
Expand Down