Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep nightly 20231010 for ExecuTorch alpha 0.1 for now #1642

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Keep nightly 20231010 for ExecuTorch alpha 0.1 for now #1642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion s3_management/manage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,12 @@
# How many packages should we keep of a specific package?
KEEP_THRESHOLD = 60

# TODO (huydhn): Clean this up once ExecuTorch has a new stable release that
# match PyTorch stable release cadence. This nightly version is currently
# referred to publicly in ExecuTorch alpha 0.1 release. So we want to keep
# nightly binaries around for now
KEEP_NIGHTLY_PACKAGES_FOR_EXECUTORCH = {datetime(2023, 10, 10, 0, 0)}

S3IndexType = TypeVar('S3IndexType', bound='S3Index')


Expand Down Expand Up @@ -201,7 +207,10 @@ def nightly_packages_to_show(self: S3IndexType) -> List[S3Object]:
if package_name not in PACKAGE_ALLOW_LIST:
to_hide.add(obj)
continue
if packages[package_name] >= KEEP_THRESHOLD or between_bad_dates(package_build_time):
if package_build_time not in KEEP_NIGHTLY_PACKAGES_FOR_EXECUTORCH and (
packages[package_name] >= KEEP_THRESHOLD
or between_bad_dates(package_build_time)
):
to_hide.add(obj)
else:
packages[package_name] += 1
Expand Down