Add thrust_11.3 explicitly, remove bad quotes, parallelize nvcc #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seemethere
approved these changes
May 4, 2021
seemethere
reviewed
May 4, 2021
windows/internal/smoke_test.bat
Outdated
| if "%CUDA_VERSION%" == "110" call internal\driver_update.bat | ||
| if "%CUDA_VERSION%" == "111" call internal\driver_update.bat | ||
| if "%CUDA_VERSION%" == "112" call internal\driver_update.bat | ||
| if DEFINED CUDA_VERSION call internal\driver_update.bat |
There was a problem hiding this comment.
Couldn't CUDA_VERSION also be set to cpu?
There was a problem hiding this comment.
Good call, I'll change this to check for inequality with cpu
malfet
approved these changes
May 11, 2021
janeyx99
force-pushed
the
fix-windows-11.3
branch
from
2af9731 to
5c8ed42
Compare
janeyx99
force-pushed
the
fix-windows-11.3
branch
from
d0e24a4 to
a2d2ce3
Compare
janeyx99
changed the title
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thrust_11.3 was moved into its separate package so we need to explicitly put it as an argument.
The quotes break installation, so removing them as they're not actually necessary
Also parallelizes nvcc for manywheel
(Tested in pytorch/pytorch#57522, sample logs https://app.circleci.com/pipelines/github/pytorch/pytorch/326891/workflows/b4a3ecdb-b340-4ccf-ac9b-a7c0b9174224/jobs/13691140)