Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cpuinfo to enable TF Build on linux ppc64le architecture #170

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

npanpaliya
Copy link

This change is needed for cpuinfo to build on linux ppc64le architecture. Without this change, Tensorflow's build fails on ppc64le.

@facebook-github-bot
Copy link
Contributor

Hi @npanpaliya!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link
Contributor

@Maratyszcza Maratyszcza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't actually add support for Linux/PPC64, only (probably) makes cpuinfo build on this platform

@npanpaliya
Copy link
Author

This doesn't actually add support for Linux/PPC64, only (probably) makes cpuinfo build on this platform

Yes @Maratyszcza ! Yes, this is just to get cpuinfo built as part of Tensorflow build. If you could help me on where and how can we add full support of Linux ppc64le in cpuinfo code, it will be great.

@smuzaffar
Copy link

Using this patch I was able to build Tensorflow 2.15.0 for pc64le.

@npanpaliya npanpaliya changed the title Add support for linux ppc64le architecture Update cpuinfo to enable TF Build on linux ppc64le architecture May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants