-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Up-to-date FreeBSD support #230
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not an expert in the OS layer. The code looks okay. Is it necessary to have freebsd instead of linux?
Hi Marat, This is an updated pull request that works fine on FreeBSD. Could you please merge it? Thanks, |
Hello, Any news on that PR ? FYI, I used it to update our pcsx2 port and it works fine here. Cheers, Ganael. |
goto cleanup; | ||
} | ||
packages = | ||
calloc(freebsd_topology.packages, sizeof(struct cpuinfo_package)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is packages the reason you're wanting a branch from linux?
The latest linux kernel on android and riscv requires packages support so it would be best to use common code to avoid freebsd diverging in the future.
Same as #172, updated to the latest cpuinfo revision.