Add initial support for powerpc64le initialization. #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds header definitions for PPC64le
* Adds support to construct the processor, core, cluster, package
and cache(L1i,L1d,L2 and L3) information reported by the system.
Test: Build and ran cpu_info on PPC64le linux machine. confirmed
that it properly reports the logical processors, cores, clusters,
packages and cache information.
malfet
reviewed
Dec 4, 2024
test/name/power-features.cc
Outdated
| int b = (uint32_t) getauxval(AT_HWCAP2); | ||
| #endif //CPUINFO_MOCK // | ||
|
|
||
| #if (b & CPUINFO_POWERPC_LINUX_FEATURE_ARCH_3_1) |
There was a problem hiding this comment.
Can you please explain how that is supposed to work?
There was a problem hiding this comment.
@malfet when AT_hwcap2 supports the feature arch_3_1(Power10) then cpuinfo_initialization should set these features mma,vsx
_```
#if (b & CPUINFO_POWERPC_LINUX_FEATURE_ARCH_3_1)
EXPECT_EQ(0, cpuinfo_has_powerpc_htm());
EXPECT_EQ(1, cpuinfo_has_powerpc_mma());
EXPECT_EQ(1, cpuinfo_has_powerpc_vsx());
src/linux/processors.c
Outdated
Comment on lines
304
to
306
| cpuinfo_log_info( | ||
| "failed to parse online status for processor %" PRIu32 " from %s", processor, processor_online_filename); | ||
| return false; |
There was a problem hiding this comment.
yeah, I will fix all the indent errors
There was a problem hiding this comment.
@malfet I have fixed indentation. could you review it
|
@malfet could you review the patch again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: