Add a null check for tracer in the Module::load_method
#6319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#6298) Summary: Pull Request resolved: #6298 When testing the [LLM Manual](https://pytorch.org/executorch/0.4/llm/getting-started.html#profiling-and-debugging), I found etdump is not generated :(. It seems to be a bug introduced in D62520386 when a `tracer` parameter was added to `Module::load_method`. It overrides the `event_tracer_.get()`, resulting `tracer` being null and passed to `program_->load_method`, thus etdump is not generated. This diff just adds a check: it `tracer` is not null, use it; otherwise use the tracer get from class member event_tracer_. Reviewed By: tarun292, Gasoonjia, dbort Differential Revision: D64481537 fbshipit-source-id: 86cecbaea2b7293be28d60f4147deb31535fa6ea (cherry picked from commit ad0e5e8)
This was referenced Oct 17, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6319
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit bbcb95a with merge base eecf74f ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
dvorjackz
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When testing the LLM Manual, I found etdump is not generated :(. It seems to be a bug introduced in D62520386 when a
tracerparameter was added toModule::load_method. It overrides theevent_tracer_.get(), resultingtracerbeing nullprogram_->load_methodis called and thus etdump is not generated.This diff just adds a check: it
traceris not null, use it; otherwise use the tracer get from class member event_tracer_.Differential Revision: D64481537