Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State parameter scheduler #2090

Merged
merged 40 commits into from
Oct 11, 2021
Merged

State parameter scheduler #2090

merged 40 commits into from
Oct 11, 2021

Conversation

fco-dv
Copy link
Contributor

@fco-dv fco-dv commented Jun 30, 2021

Fixes #1913

Description:
Enlarge the scope of ParamScheduler like it is done in MONAI to schedule any hyperparameter while ensuring backward compatibility.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added docs module: handlers Core Handlers module labels Jun 30, 2021
@fco-dv fco-dv marked this pull request as draft June 30, 2021 19:26
@vfdev-5 vfdev-5 mentioned this pull request Jul 7, 2021
Merged
3 tasks
@fco-dv fco-dv marked this pull request as ready for review July 19, 2021 15:49
vfdev-5
vfdev-5 reviewed Jul 19, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fco-dv , I haven't yet go into details but would like to propose few global naming changes

ignite/handlers/param_scheduler.py Outdated Show resolved Hide resolved
ignite/handlers/param_scheduler.py Outdated Show resolved Hide resolved
ignite/handlers/param_scheduler.py Outdated Show resolved Hide resolved
sdesrozis
sdesrozis reviewed Oct 1, 2021
View reviewed changes
ignite/handlers/state_param_scheduler.py
keys_to_remove = ["save_history"]
for key in keys_to_remove:
if key in scheduler_kwargs:
del scheduler_kwargs[key]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fco-dv Could we test this part ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but what do you have in mind precisely :) ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test that executes this function and thus cover this line 99.

vfdev-5
vfdev-5 reviewed Oct 11, 2021
View reviewed changes
ignite/handlers/param_scheduler.py Outdated Show resolved Hide resolved
ignite/handlers/param_scheduler.py Outdated Show resolved Hide resolved
ignite/handlers/state_param_scheduler.py Outdated Show resolved Hide resolved
ignite/handlers/state_param_scheduler.py Outdated Show resolved Hide resolved
ignite/handlers/state_param_scheduler.py Outdated Show resolved Hide resolved
tests/ignite/handlers/test_state_param_scheduler.py Outdated Show resolved Hide resolved
tests/ignite/handlers/test_state_param_scheduler.py Outdated Show resolved Hide resolved
tests/ignite/handlers/test_state_param_scheduler.py Outdated Show resolved Hide resolved
tests/ignite/handlers/test_state_param_scheduler.py Outdated Show resolved Hide resolved
tests/ignite/handlers/test_state_param_scheduler.py Outdated Show resolved Hide resolved
vfdev-5
vfdev-5 reviewed Oct 11, 2021
View reviewed changes
ignite/handlers/state_param_scheduler.py Outdated Show resolved Hide resolved
ignite/handlers/state_param_scheduler.py Outdated Show resolved Hide resolved
ignite/handlers/state_param_scheduler.py Outdated Show resolved Hide resolved
vfdev-5
vfdev-5 approved these changes Oct 11, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fco-dv , finally we can land it

@vfdev-5 vfdev-5 enabled auto-merge (squash) October 11, 2021 09:03
@fco-dv fco-dv mentioned this pull request Oct 11, 2021
Closed
@vfdev-5 vfdev-5 merged commit 81e13e1 into pytorch:master Oct 11, 2021
@fco-dv fco-dv deleted the any_parameter_scheduler branch October 24, 2021 16:40
@fco-dv fco-dv mentioned this pull request Oct 26, 2021
Open
fco-dv added a commit to fco-dv/ignite that referenced this pull request Nov 14, 2021
@fco-dv
pytorch#2090 make work EMAHandler with StateParamScheduler
0ea2c56
vfdev-5 added a commit that referenced this pull request Nov 21, 2021
@fco-dv @vfdev-5
Paramscheduler emahandler (#2326)
41f33fc 
* #2090 make work EMAHandler with StateParamScheduler

* #2295 update docstring for parameter `create_new`

* #2295 fixing attach method logic and update associated tests

* #2295 fix unused import / remove useless test

* #2295 fix tests

* #2295 rm else statement

* Update ignite/handlers/state_param_scheduler.py

Co-authored-by: vfdev <vfdev.5@gmail.com>

* Update ignite/handlers/state_param_scheduler.py

Co-authored-by: vfdev <vfdev.5@gmail.com>

* #2295 update tests assert messages

* #2295 update tests, add working example with EMAHandler

Co-authored-by: vfdev <vfdev.5@gmail.com>
fco-dv added a commit to fco-dv/ignite that referenced this pull request Nov 23, 2021
@fco-dv @vfdev-5
Paramscheduler emahandler (pytorch#2326)
c402cd7 
* pytorch#2090 make work EMAHandler with StateParamScheduler

* pytorch#2295 update docstring for parameter `create_new`

* pytorch#2295 fixing attach method logic and update associated tests

* pytorch#2295 fix unused import / remove useless test

* pytorch#2295 fix tests

* pytorch#2295 rm else statement

* Update ignite/handlers/state_param_scheduler.py

Co-authored-by: vfdev <vfdev.5@gmail.com>

* Update ignite/handlers/state_param_scheduler.py

Co-authored-by: vfdev <vfdev.5@gmail.com>

* pytorch#2295 update tests assert messages

* pytorch#2295 update tests, add working example with EMAHandler

Co-authored-by: vfdev <vfdev.5@gmail.com>
Ishan-Kumar2 pushed a commit to Ishan-Kumar2/ignite that referenced this pull request Dec 26, 2021
@fco-dv @vfdev-5 @Ishan-Kumar2
Paramscheduler emahandler (pytorch#2326)
7211e33 
* pytorch#2090 make work EMAHandler with StateParamScheduler

* pytorch#2295 update docstring for parameter `create_new`

* pytorch#2295 fixing attach method logic and update associated tests

* pytorch#2295 fix unused import / remove useless test

* pytorch#2295 fix tests

* pytorch#2295 rm else statement

* Update ignite/handlers/state_param_scheduler.py

Co-authored-by: vfdev <vfdev.5@gmail.com>

* Update ignite/handlers/state_param_scheduler.py

Co-authored-by: vfdev <vfdev.5@gmail.com>

* pytorch#2295 update tests assert messages

* pytorch#2295 update tests, add working example with EMAHandler

Co-authored-by: vfdev <vfdev.5@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdesrozis sdesrozis sdesrozis left review comments

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
docs module: handlers Core Handlers module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add any parameter scheduling
3 participants
@fco-dv @vfdev-5 @sdesrozis