Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled LRFinder to run multiple epochs #2200

Merged
merged 6 commits into from
Sep 19, 2021
Merged

Enabled LRFinder to run multiple epochs #2200

merged 6 commits into from
Sep 19, 2021

Conversation

KickItLikeShika
Copy link
Contributor

Fixes #1357

Previously LRFinder raises a warning if num_iter was equivalent to more than 1 epoch, fixed that, and it runs more than 1 epoch now.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: handlers Core Handlers module label Sep 16, 2021
vfdev-5
vfdev-5 reviewed Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @KickItLikeShika
I left few comments to improve the PR

tests/ignite/handlers/test_lr_finder.py Outdated Show resolved Hide resolved
ignite/handlers/lr_finder.py Outdated Show resolved Hide resolved
vfdev-5
vfdev-5 approved these changes Sep 19, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, Ahmed ! Looks good

@vfdev-5 vfdev-5 enabled auto-merge (squash) September 19, 2021 13:15
@vfdev-5 vfdev-5 merged commit 9879d43 into pytorch:master Sep 19, 2021
@KickItLikeShika KickItLikeShika deleted the lrfinder-num-iter branch September 19, 2021 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
module: handlers Core Handlers module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FastaiLRFinder does not run more than 1 epoch. Why?
2 participants
@KickItLikeShika @vfdev-5