Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python 3.6 support removed due to EOL, added py39 to pytorch-version-tests #2365

Merged
merged 9 commits into from
Dec 20, 2021
Merged

python 3.6 support removed due to EOL, added py39 to pytorch-version-tests #2365

merged 9 commits into from
Dec 20, 2021

Conversation

bibhabasumohapatra
Copy link
Contributor

Fixes #2363

Description: Let's remove python 3.6 from our CI from due to EOL, 2021-12-23 (https://www.python.org/downloads/)

hey @vfdev-5 ,
to remove python-version 3.6 and py36 support from
IG I can remove that the following way from these paths ,right?

  1. .github/workflows/unit-tests.yml

  2. .github/workflows/pytorch-version-tests.yml

python-version: [3.6, 3.7, 3.8, 3.9] -> python-version: [3.7, 3.8, 3.9]

  1. pyproject.toml
    target-version = ['py36', 'py37', 'py38'] -> target-version = [ 'py37', 'py38']

Check list:

  • removing support for python 3.6 from CI

@github-actions github-actions bot added the ci CI label Dec 18, 2021
vfdev-5
vfdev-5 reviewed Dec 18, 2021
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
@sdesrozis
Copy link
Contributor

@bibhabasumohapatra All the tests failed. It seems related to #2365 (comment)

Could you explore that ? Thanks !

@bibhabasumohapatra
Copy link
Contributor Author

@bibhabasumohapatra All the tests failed. It seems related to #2365 (comment)

Hey! @sdesrozis I was asking that - it shows
Error: Invalid value for '-t' / '--target-version': invalid choice: py39. (choose from py27, py33, py34, py35, py36, py37, py38)
why is that?

@sdesrozis
Copy link
Contributor

sdesrozis commented Dec 20, 2021 •
edited
Loading

Hey! @sdesrozis I was asking that - it shows Error: Invalid value for '-t' / '--target-version': invalid choice: py39. (choose from py27, py33, py34, py35, py36, py37, py38) why is that?

I don't know. See #2365 (comment), you added py39 in pyproject.toml and it seems to make it fail.

@bibhabasumohapatra
Copy link
Contributor Author

bibhabasumohapatra commented Dec 20, 2021 •
edited
Loading

@sdesrozis @vfdev-5 If I add py39 it fails, the version of black we are using only allows -
-t, --target-version [py27|py33|py34|py35|py36|py37|py38]
checked this by using black -h command
so if we add py39 fails all tests. may updating black solve this problem.

@sdesrozis
Copy link
Contributor

@sdesrozis @vfdev-5 If I add py39 it fails, the version of black we are using only allows -
-t, --target-version [py27|py33|py34|py35|py36|py37|py38]
checked this by using black -h command
so if we add py39 fails all tests. may updating black solve this problem.
Now I have checked the tests and all checks are passed without 'py39'
image

Let’s see whether the CI works fine

sdesrozis
sdesrozis approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bibhabasumohapatra Thank you, LGTM !

trsvchn
trsvchn approved these changes Dec 20, 2021
View reviewed changes
Copy link
Collaborator

@trsvchn trsvchn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bibhabasumohapatra for the PR! LGMT!

@vfdev-5 vfdev-5 merged commit 59bff0b into pytorch:master Dec 20, 2021
@bibhabasumohapatra bibhabasumohapatra deleted the python-3.6-removed branch December 21, 2021 05:46
@vfdev-5 vfdev-5 changed the title python 3.6 support removed due to EOL, 2021-12-23 python 3.6 support removed due to EOL, added py39 to pytorch-version-tests Dec 23, 2021
Ishan-Kumar2 pushed a commit to Ishan-Kumar2/ignite that referenced this pull request Dec 26, 2021
@bibhabasumohapatra @vfdev-5
@sdesrozis @Ishan-Kumar2
python 3.6 support removed due to EOL, 2021-12-23 (pytorch#2365)
f1c2171 
* this removes python 3.6 support due to EOL, 2021-12-23

* added py39

* Update pyproject.toml

Co-authored-by: vfdev <vfdev.5@gmail.com>

* adds python 3.9

* Update pytorch-version-tests.yml

* black no support py39

Co-authored-by: vfdev <vfdev.5@gmail.com>
Co-authored-by: Sylvain Desroziers <sylvain.desroziers@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdesrozis sdesrozis sdesrozis approved these changes

@trsvchn trsvchn trsvchn approved these changes

@vfdev-5 vfdev-5 Awaiting requested review from vfdev-5

Assignees
No one assigned
Labels
ci CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove python 3.6 support due to EOL, 2021-12-23
4 participants
@bibhabasumohapatra @sdesrozis @vfdev-5 @trsvchn