Removed warning in DDP if Metric.reset/update are not decorated. #2549
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Context:
reinit__is_reduced
andsync_all_reduce
decorators are optional helpers to compute full metric value in distributed context. They should be optional and users basically are free to skip them and perform all_reduce-like ops on accumulated variable during compute on their own. And also make sure that compute wont perform collective ops twice if no reset/update were called.reinit__is_reduced
decorator is needed to avoid multiple reductions if compute method is called several times without reseting or updating...If user develop their own metric and prefer to all_reduce with their means, they see a warning in DDP.
Check list: