Add rank param to Checkpoint #2633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
reviewed
Jul 28, 2022
There was a problem hiding this comment.
Thanks for the PR @sadra-barikbin !
I haven't checked everything and will continue the review later
ignite/handlers/checkpoint.py
Outdated
Comment on lines
825
to
826
| # all tpu procs should enter here as internally performs sync across device | ||
| self._save_func(checkpoint, path, xm.save) |
There was a problem hiding this comment.
For XLA all procs should enter xm.save, but now you added if self.save_on_rank == idist.get_rank(): on the top, so only one proc will enter this function. Am I missing something?
There was a problem hiding this comment.
I corrected it
ignite/handlers/checkpoint.py
Outdated
Comment on lines
175
to
176
| When running on XLA devices or using :class:`~torch.distributed.optim.ZeroRedundancyOptimizer`, it | ||
| should be run in all processes, otherwise application can get stuck on saving the checkpoint. |
There was a problem hiding this comment.
We may need to rephrase this sentence...
There was a problem hiding this comment.
How exactly do you mean?
vfdev-5
reviewed
Aug 10, 2022
|
|
||
| import torch | ||
| import torch.nn as nn | ||
| from torch.distributed.optim import ZeroRedundancyOptimizer |
There was a problem hiding this comment.
Ignite is supposed to work with pytorch 1.3.1 where ZeroRedundancyOptimizer is absent. We have to deal with this import differently.
sadra-barikbin
deleted the
feature-add-rank-param-to-checkpoint-issue-2623
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2623
Description:
Check list: