Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add save_on_rank argument to DiskSaver and Checkpoint #2641

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Add save_on_rank argument to DiskSaver and Checkpoint #2641

merged 1 commit into from
Aug 14, 2022

Conversation

sadra-barikbin
Copy link
Collaborator

@sadra-barikbin sadra-barikbin commented Aug 13, 2022 •
edited by vfdev-5
Loading

Related to #2635

Description: Added save_on_rank to DiskSaver, Checkpoint and ModelCheckpoint classes.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: handlers Core Handlers module label Aug 13, 2022
@sadra-barikbin sadra-barikbin changed the title Implement feature Add save_on_rank argument to DiskSaver and Checkpoint Aug 13, 2022
vfdev-5
vfdev-5 approved these changes Aug 14, 2022
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sadra-barikbin

However, I do not think this resolves #2635 as it would also stuck on DiskSaver._check_and_setup in ctor.

@vfdev-5 vfdev-5 merged commit 83f8cc7 into pytorch:master Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
module: handlers Core Handlers module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sadra-barikbin @vfdev-5