-
-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#2878: Adds Siamese Network example #2882
Conversation
@vfdev-5 please check the PR. I am unable to understand the origin of error. Is the code formatter adding the following line, ✨ 1 file would be formatted, 267 files already formatted ✨, by itself since it does not show up when formatter is run locally |
@DeepC004 sure, I'll check the PR as soon as possible. To reformat please do
|
Thank you. I was running the code formatter in the tests folder earlier, hence the code formatter was not picking up all the files for formatting. |
@DeepC004 it should be added to https://github.com/pytorch-ignite/examples not pytorch/examples See #2878 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @DeepC004 !
I left few comments on improving the code and also suggested few changes. Let me know what you think.
@vfdev-5 I have made the changes. May you please review them |
@DeepC004 Thanks ! Can you share here training results (logs, metrics), does model converge etc ? |
@DeepC004 I just run it locally and it is very very slow. Can you run some profiling to get an idea where is a bottleneck ? |
Yes, even I ran it locally before submitting and it took me a couple hours to complete the training (with cuda enabled). The |
Sounds good.
The point is not to add profiling into the code but just understand why GPU is almost idle during the run |
Thanks for the update, @DeepC004 ! |
@vfdev-5 I have made the changes. The run time is much better now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeepC004 I left few more comments.
By the way have you committed the changes, because I see a lot of unaddressed comments
Oh, I believe I commited the wrong file with incomplete changes. I will update it. |
@vfdev-5 May you please review the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeepC004 thanks for pinging. I left other comments to address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few other nits and it will be good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will look into it. Thank you! |
Related to #2878
Description:
I have added an example on Siamese Networks in the examples folder along with requirements.txt and README.md.
I have tested the network locally with different parameters and set the default parameters to ones which perform the best.
Note: I am also working on Google Colab Notebook for the same and will add it to pytorch-ignite/examples soon.
Check list: