Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing mps tests #3145

Merged
merged 6 commits into from
Nov 27, 2023
Merged

Fix failing mps tests #3145

merged 6 commits into from
Nov 27, 2023

Conversation

pranavvp16
Copy link
Contributor

Draft PR which fixes distributed tests for mps

@sweep-ai Sweep AI
Copy link
Contributor

sweep-ai bot commented Nov 23, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@pranavvp16 pranavvp16 marked this pull request as ready for review November 27, 2023 17:13
vfdev-5
vfdev-5 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pranavvp16

CI failures are unrelated.

@vfdev-5 vfdev-5 merged commit 514e2f8 into pytorch:master Nov 27, 2023
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pranavvp16 @vfdev-5