Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make lr finder error message more helpful. #3160

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

leej3
Copy link
Collaborator

@leej3 leej3 commented Dec 4, 2023

Fixes #3152

Description:
Small change to an error message to help users encountering type errors when using the fast ai learning rate finder. As mentioned in original issue, there's no compelling reason to update the docs. Helping users to transform the trainer output if that is the cause of the error should be sufficient.

@github-actions github-actions bot added the module: handlers Core Handlers module label Dec 4, 2023
Copy link
Contributor

sweep-ai bot commented Dec 4, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Dec 4, 2023

To repro formatting issue:

  bash ./tests/run_code_style.sh install
  bash ./tests/run_code_style.sh lint

and to fix it :

  bash ./tests/run_code_style.sh fmt

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks John, LGTM!

@vfdev-5 vfdev-5 merged commit 0660cfa into pytorch:master Dec 4, 2023
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: handlers Core Handlers module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FastaiLRFinder usage
2 participants